ToolBarButton - Meaning of select() method is reversed

[Ming Zhe Huang]

The meaning of select() method is reversed. When writing the following code to deselect a toolbar button, actually we're selecting it.

toggleBtn.select(false); try to deselect, but actually select

Check ToolBarButton.js line 58, the passed in parameter name is "deselect". I think it should be renamed as "select".

[Ming Zhe Huang]

BTW, the meaning of ToolBarButton?.selected is also reversed here. That will cause trouble if there's need to check that flag.

[ykami]

Thanks, I agree. The API was not good. It has to be consistent.

[ykami]

(In [25736]) Fixes #13378 !strict Made the select API consistent. TabBarButton? and ToolBarButton? had select(Boolean), while ListItem? had select/deselect. Added deselect to TabBarButton? and ToolBarButton?. The boolean argument for select() is still valid to keep backward compatibility.

[ykami]

(In [25859]) Refs #13378 !strict Fixed the toggle button logic in defaultClickAction.