Opened 8 years ago

Closed 8 years ago

#13366 closed defect (fixed)

dojox.mobile test_transition-animations-standard.html broken

Reported by: cjolif Owned by: ykami
Priority: high Milestone: 1.7
Component: DojoX Mobile Version: 1.7.0b1
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

In trunk http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/mobile/tests/test_transition-animations-standard.html is not working anymore (shows up in tons of other demos like mobileCharting demo).

Change History (5)

comment:1 Changed 8 years ago by cjolif

Note: I did not test on mobile, just Chrome and Firefox.

comment:2 Changed 8 years ago by ykami

Currently dojo base in the trunk looks to be changing and not very stable. It looks recent dojo/dom related changes broke something. A script error occurs in dojo/dom/class.js.

comment:3 Changed 8 years ago by cjolif

Yes, this comes from dojo.hasClass (dom/class.contains) that now crashes if the DomNode? is a Text node... while it used to "work". I have created #13367 for that. In any case maybe dojox.mobile could avoid calling hasClass on Text node that anyway can't have classes.

comment:4 Changed 8 years ago by ykami

Status: newassigned

ok, thanks for your suggestion. I'll fix the dojox.mobile code to check if node is an element node or not just in case #13367 will not be fixed.

comment:5 Changed 8 years ago by ykami

Keywords: 1.7-mobile added
Resolution: fixed
Status: assignedclosed

(In [25725]) Fixes #13366 !strict Check if node is an element node or not so as not to pass a text node to dojo.hasClass.

Note: See TracTickets for help on using tickets.