Opened 9 years ago

Closed 9 years ago

#13358 closed defect (fixed)

tree._dndContainer.constructor: Attribute map is unused an can be deleted

Reported by: Simon Speich Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

In the constructor the map object is defined: 

constructor: function(tree, params) {
	...
	this.map = {};
	...
}

but never used. Instead _dndContainer uses this.selection in this.getItem() (which is confusing/unfortunate IMHO, since it is only defined in the child class tree._dndSelector, but not in the _dndContainer).

Change History (3)

comment:1 Changed 9 years ago by Douglas Hays

Owner: set to Dustin Machi

map attribute added in [10486]

comment:2 Changed 9 years ago by bill

Milestone: tbd → 1.7
Owner: changed from Dustin Machi to bill
Status: new → assigned

I'll fix.

comment:3 Changed 9 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [26535]:

remove unused map attribute, and move getItem() method to appropriate place in class hierarchy, fixes #13358 !strict.

Note: See TracTickets for help on using tickets.