Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#13350 closed task (fixed)

remove FF3 code at some point

Reported by: Douglas Hays Owned by: Eugene Lazutkin
Priority: high Milestone: 1.8
Component: HTML Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:


dom-geometry.js contains

}else if(has("ff") == 3){
        // In FF3 you have to subtract the document element margins.
        // Fixed in FF3.5 though.
        var cs = style.getComputedStyle(dh), px = style.toPixelValue;
        ret.x -= px(dh, cs.marginLeft) + px(dh, cs.borderLeftWidth);
        ret.y -= px(dh, cs.marginTop) + px(dh, cs.borderTopWidth);

which should be removed at some point in the near future.

Change History (9)

comment:1 Changed 10 years ago by bill

Component: GeneralHTML

comment:2 Changed 10 years ago by bill

Owner: changed from James Burke to Eugene Lazutkin

comment:3 Changed 10 years ago by Eugene Lazutkin

Status: newassigned

When FF3 code should be removed?

comment:5 Changed 10 years ago by Douglas Hays

But this is 3.0 code. James wanted to leave it in for a while back in 1.5.

comment:6 Changed 10 years ago by bill

Oops, ignore my above comment then. I think it's fine to remove it now (of course, I said the same thing before 1.5 was released, but there's an even better argument now).

comment:7 Changed 9 years ago by Eugene Lazutkin

Apparently all Firefox 3.x versions are retired now, even the venerable 3.6, which is not affected by the code in question. I will remove the code.

comment:8 Changed 9 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

In [28240]:

dom-geometry: removed FF 3.0 specific correction code, fixes #13350, !strict, thx doughays!

comment:9 Changed 9 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.