Opened 8 years ago

Closed 8 years ago

#13348 closed defect (fixed)

[PATCH][CLA] copyright in prefix is treated as the copyright header

Reported by: liucougar Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by liucougar)

in the old build system, the third element in a prefix list is the path to a file whose content should be used as the copyright header for all javascript files under that prefix

the new build system seems to just use the third element as the content of the copyright header

proposed patch:

  • build/v1xProfiles.js

     
    151151                               // pair a [mid, path], mid, a dotted module id, path relative to dojo directory
    152152                               topLevelMids[pair[0]]= 1;
    153153                               prefixMap[pair[0]]= pair[1];
    154                                copyrightMap[pair[0]]= pair[2];
     154                               copyrightMap[pair[0]]= pair[2] && readFileSync(pair[2], "utf8") || "";
    155155                       });
    156156
    157157                       // make sure we have a dojo prefix; memorize it;

Change History (2)

comment:1 Changed 8 years ago by liucougar

Description: modified (diff)
Summary: copyright in prefix is treated as the copyright header[PATCH][CLA] copyright in prefix is treated as the copyright header

comment:2 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [25946] fixed and added the ability to include either copyright text directly or a filename. If anything is found at position [2] of a prefixes item, then it is assumed to be a filename. If the file does not exist, then it is assumed to be a copyright message.

Note: See TracTickets for help on using tickets.