Opened 8 years ago

Closed 8 years ago

#13347 closed defect (fixed)

dojo/_base/sniff wrong return or wrong usage in dojo/dom-style.js (for example)

Reported by: Marc Durocher Owned by: Kris Zyp
Priority: high Milestone: 1.7
Component: General Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

in trunk revision 25679 dojo/_base/sniff returns 'has' and not 'dojo'. In some (many) places like dojo/dom-style.js we have :

define(["./_base/kernel", "./_base/sniff", "./dom"], function(dojo, sniff, dom){ ....... if(sniff.isIE) .....

which is not consistent with the return of dojo/_base/sniff

As a result many tests fail on IE (8) with : Error: 'ownerDocument.defaultView' is null or not an object

sniff should then return dojo or usages of sniff should use sniff.ie

Change History (2)

comment:1 Changed 8 years ago by Douglas Hays

Milestone: tbd1.7
Owner: set to Kris Zyp

comment:2 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

sniff.js now returns "has". The occurences of sniff.* were fixed by [25681], [25682], [25683], [25687], [25689].

Note: See TracTickets for help on using tickets.