Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13335 closed enhancement (fixed)

Enhance dojo/text plugin to make use of dojo-combo-api feature

Reported by: ddumont Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

See: http://bugs.dojotoolkit.org/ticket/13334

Text plugin can make use of changing a require for dojo/text!dojo/foo/foo.html to a require for resource!dojo/foo/foo.html instead of making a separate xhr for the resource.

Attachments (1)

text.js.patch (1.1 KB) - added by Adam Peller 8 years ago.
patch from Chuck Dumont (IBM, CCLA)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by ben hockey

Component: GeneralLoader
Owner: set to Rawld Gill

comment:2 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:3 Changed 8 years ago by ddumont

One of our committers at IBM should be posting something soon for you to review. Please let me know what you think.

Changed 8 years ago by Adam Peller

Attachment: text.js.patch added

patch from Chuck Dumont (IBM, CCLA)

comment:4 Changed 8 years ago by Rawld Gill

Milestone: tbd1.7

comment:5 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

The design of combo service plugins has changed since this patch was offered.

Assuming a combo service provided a text plugin, say "comboText", then the way to get that plugin to replace the dojo/text plugin is to use an alias configuration, e.g.:

require({
  aliases:[
    ["dojo/text", "comboText"]
  ]
});

With this, e.g., "dojo/text!some/text/resource.txt" will be seen as "comboText!some/text/resource.txt" and the combo service will be used to load the text.

comment:6 Changed 8 years ago by ddumont

But then dojo.cache wouldn't work, because the text plugin now defines it. Right?

comment:7 Changed 8 years ago by ddumont

This actually seems to be working fine. :) thanks!

Note: See TracTickets for help on using tickets.