Opened 8 years ago

Closed 8 years ago

#13334 closed enhancement (fixed)

Support for pseudo plugins handled by the dojo-combo-api extension

Reported by: ddumont Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The loader should mark as resolved/loaded/executed and not attempt to load the "resource!" or "resourceBin!" plugin when has(dojo-combo-api). These plugin resources should also be passed into the combo.add() function to determine if the loader can handle them. combo.add('resource!dojo/foo/foo.html').

Is it true that at the point where combo.add is called, the resource passed to the plugin has already been normalized by the loader?

Please suggest other names if you prefer different ones!

Attachments (1)

dojo.js.patch (1.7 KB) - added by Adam Peller 8 years ago.
Patch from Dan Dumont (IBM, CCLA)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by ben hockey

Component: GeneralLoader
Owner: set to Rawld Gill

comment:2 Changed 8 years ago by ddumont

One of our committers at IBM should be posting something soon for you to review. Please let me know what you think.

Changed 8 years ago by Adam Peller

Attachment: dojo.js.patch added

Patch from Dan Dumont (IBM, CCLA)

comment:3 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:4 Changed 8 years ago by Rawld Gill

Milestone: tbd1.7

comment:5 Changed 8 years ago by Rawld Gill

In [26645]:

fixed trying to define a combo plugin before the loader is fully initialized; refs #13334; !strict

comment:6 Changed 8 years ago by Rawld Gill

In [26646]:

fixed improper combo injecting logic; refs #13334; !strict

comment:7 Changed 8 years ago by Rawld Gill

In [26647]:

enhanced combo plugin to allow a factory function; refs #13334; !strict

comment:8 Changed 8 years ago by Rawld Gill

In [26648]:

fixed undefined error in combo logic; refs #13334; !strict

comment:9 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.