Opened 8 years ago

Closed 8 years ago

#13331 closed enhancement (fixed)

[patch] AMD refactoring of dojox.lang.functional.scan

Reported by: Kitson Kelly Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: Dojox Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Attached is an AMD refactoring of the dojox.lang.function.scan. CCLA on file.

Attachments (2)

scan.js.patch​ (876 bytes) - added by Kitson Kelly 8 years ago.
Patch of dojox.lang.functional.scan
scan.js.2.patch​ (863 bytes) - added by Kitson Kelly 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Kitson Kelly

Attachment: scan.js.patch​ added

Patch of dojox.lang.functional.scan

comment:1 Changed 8 years ago by Adam Peller

Milestone: tbd → 1.7
Owner: changed from Adam Peller to Eugene Lazutkin

comment:2 Changed 8 years ago by bill

BTW the "var d = dojo" should be removed as it serves no purpose (shrinksafe or closure will compress the "dojo" name automatically).

comment:3 Changed 8 years ago by Kitson Kelly

I am updating the patch based on bill's comment. I was following a similar refactoring of dojox.lang.function.array so there could be other improvements had, but I have only been submitting the patches for the things that I am stumbling over when trying to get one of my apps to work on async loading in 1.7.

Changed 8 years ago by Kitson Kelly

Attachment: scan.js.2.patch​ added

comment:4 Changed 8 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [25652]) AMD conversion. fixes #13331, refs #12863 \!strict

Note: See TracTickets for help on using tickets.