Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13328 closed enhancement (fixed)

[patch] AMD refactoring of dojox.form.BusyButton

Reported by: Kitson Kelly Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: DojoX Form Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

This is an AMD refactoring of the dojox.form.BusyButton. Tested the patch against test_BusyButton.html. CCLA on file.

Attachments (1)

BusyButton.js.patch (1.0 KB) - added by Kitson Kelly 8 years ago.
AMD Refactoring for BusyButton?

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Kitson Kelly

Attachment: BusyButton.js.patch added

AMD Refactoring for BusyButton?

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Owner: changed from dante to Rawld Gill

Rawld, can you take a look? I tested the patch against test_BusyButton.html too, but it didn't work for me. It gives a loader error:

Object { src="dojoLoader", id="multipleDefine"}
Object { pid="dojo", mid="dojo/parser", more...}

There's one obvious mistake in the patch, that it's missing all of the dojo core dependencies except for dojo/_base/kernel, but even after fixing (by changing dojo/_base/kernel to dojo/main) I still get the same error (this is testing over HTTP on FF5/mac).

comment:2 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

Tried test_BusyButton.html as of [25945] and it works for me.

comment:3 Changed 8 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.