Opened 8 years ago

Last modified 3 years ago

#13303 assigned defect

[patch][cla] FloatingPane defect on resize browser window (on FF)

Reported by: nicola.besagni Owned by: dylan
Priority: high Milestone: 1.15
Component: DojoX Layout Version: 1.6.1
Keywords: FloatingPane Cc:
Blocked By: Blocking:

Description

I create a floating pane; show it; then move it to another position (via mouse). Now I resize the browser window (via mouse) (or maximize it, or restore it from maximize). The floating pane return to its original position This not happen when I minimize and restore browser window.

I'm using 1.6.1 and FF5. This noo happen in 1.6 (from Google CDN) This not happen in IE8

I attach file (copied from your example doc)

Attachments (1)

test.html (1.8 KB) - added by nicola.besagni 8 years ago.
using dojo-release-1.6.1

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by nicola.besagni

Attachment: test.html added

using dojo-release-1.6.1

comment:1 Changed 8 years ago by Adam Peller

Component: DojoxDojoX Layout
Owner: changed from Adam Peller to dante

comment:2 Changed 6 years ago by dylan

Milestone: tbd1.9
Owner: changed from dante to dylan
Status: newassigned
Summary: FloatingPane defect on resize browser window (on FF5)FloatingPane defect on resize browser window (on FF)

Still an issue on FF19.

comment:3 Changed 6 years ago by bitpshr

I just looked into dojox/layout/tests/test_FloatingPane/html as well as the provided test page (which is just a Dojo example) and I noticed a few points that are relevant here:

  • Regardless of Dojo version (I personally verified this using http://ajax.googleapis.com/ajax/libs/dojo/1.6/dojo/dojo.xd.js) minimizing a window will never trigger a window resize event
  • Maximizing a window that was previously minimized (thus only restoring the window to view, not changing its dimensions) will also not trigger a resize event
  • Maximizing a window that was previously not minimized will trigger a resize event, since the window is staying visible and changing dimensions
  • "Un-maximizing" or restoring a window that was previously maximized to its original dimensions will also trigger a resize event

Bottom line: a window resize event is fired any time the browser window changes dimensions - not any time it is maximized or minimized. This has been the case with all past versions of Dojo (including 1.6) and was verified.

I verified that the original position of a FloatingPane? will always get restored when a proper resize event is fired using Dojo 1.6 and greater. Unless more specific information is provided, I'm suggesting we close this one.

comment:4 Changed 6 years ago by dylan

I guess the question is, why would you want it to return to its original position when a resize event occurs... it's probably not the behavior I would want. Is this a flag that can be set, or does a resize always restore to its original position?

comment:5 Changed 6 years ago by dylan

Milestone: 1.92.0

Unfortunately, I'm not going to be able to land a change for this in time for 1.9.

comment:6 Changed 5 years ago by dylan

Milestone: 2.01.10

https://github.com/dojo/dojox/pull/68 has a possible solution for this.

comment:7 Changed 5 years ago by dylan

Summary: FloatingPane defect on resize browser window (on FF)[patch][cla] FloatingPane defect on resize browser window (on FF)

comment:8 Changed 5 years ago by dylan

Fixed my branch for this in https://github.com/dojo/dojox/pull/96

comment:9 Changed 5 years ago by dylan

Milestone: 1.101.11

I'm pushing this to 1.11. I won't have time to get this right by the deadline. If someone really needs this, they can use the patch as-is for the moment.

comment:10 Changed 4 years ago by dylan

Milestone: 1.111.12

comment:11 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.