Opened 10 years ago
Closed 9 years ago
#13282 closed defect (fixed)
[patch] Stateful: Calling unwatch multiple times removes arbitrary callbacks
Reported by: | mbulman | Owned by: | Kris Zyp |
---|---|---|---|
Priority: | blocker | Milestone: | 1.8 |
Component: | General | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If you call unwatch() on the return of watch() multiple times, it does a splice from -1:1 which removes arbitrary callbacks that it shouldn't. Test case and patch attached.
Attachments (1)
Change History (5)
Changed 10 years ago by
Attachment: | fix_unwatch.diff added |
---|
comment:1 Changed 10 years ago by
Owner: | set to bill |
---|
comment:2 Changed 10 years ago by
Owner: | changed from bill to Kris Zyp |
---|
comment:3 Changed 9 years ago by
Milestone: | tbd → 1.8 |
---|---|
Priority: | high → blocker |
Summary: | Stateful: Calling unwatch multiple times removes arbitrary callbacks → [patch] Stateful: Calling unwatch multiple times removes arbitrary callbacks |
Marking 1.8 blocker to get some eyes on this since unwatch on handles shouldn’t be destroying other handles. mbulman do you have a signed CLA?
Note: See
TracTickets for help on using
tickets.
Presumably this is for Kris, unless it's really about dijit, but sounds like it's about Stateful.