Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#13279 closed feature (fixed)

Dialog: confirmation dialog

Reported by: tokeefe Owned by: bill
Priority: low Milestone: 1.10
Component: Dijit Version: 1.7.0b1
Keywords: confirmation dialog Cc:
Blocked By: Blocking:

Description (last modified by bill)

I would like to propose adding a confirmation dialog to dojo. I have implemented this as an extension of dijit.Dialog and I've attached the source here

Attachments (1)

ConfirmDialog.zip (1.1 KB) - added by tokeefe 8 years ago.
ConfirmDialog? source

Download all attachments as: .zip

Change History (17)

Changed 8 years ago by tokeefe

Attachment: ConfirmDialog.zip added

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Milestone: tbdfuture
Summary: Dojo Confirmation DialogDialog: confirmation dialog

See also #2256. I've seen this request a few times, maybe it's worth adding. (Note that we can't look at your code unless you've filed a CLA, have you?)

comment:2 Changed 8 years ago by tokeefe

I just filed my CLA. Feel free to look review the code.

comment:3 Changed 7 years ago by bill

Priority: highlow

comment:4 Changed 7 years ago by Kitson Kelly

Owner: set to tokeefe
Status: newpending
Summary: Dialog: confirmation dialog[patch] Dialog: confirmation dialog

Could not find a CLA under tokeefe.

Also, we are unlikely to add this to DojoX at this point, it should be setup as community package on packages.dojotoolkit.org. Apologies for the long running ticket.

comment:5 Changed 7 years ago by bill

Owner: tokeefe deleted
Status: pendingnew
Summary: [patch] Dialog: confirmation dialogDialog: confirmation dialog

Actually this is marked for dijit, not dojox. I won't use the patch since there's no CLA (and since it's a pretty trivial thing), but probably worth adding an AlertDialog widget at some point. It was also filed as #2256.

comment:6 Changed 7 years ago by freddefisk

If you are going to add a "confirmation dialog" to the set of standard components I would like to see that it's customizable and not just just a dialog displaying OK/cancel buttons.

Please considder things like:

  • Any number of buttons with selecable labels.
  • Customizable default (selected when the user press enter) and cancel (selected when the user press ESC) buttons.
  • A set of common icons that can be displayed in the dialog, like a question mark, exclamation mark, error symbol.

comment:7 Changed 7 years ago by bill

freddefisk, dijit/Dialog is already customizable w.r.t which buttons are shown. See the second example of http://dojotoolkit.org/reference-guide/1.8/dijit/Dialog.html#dijit-dialog.

I agree with the other two points, although they really apply to Dialog itself rather than to a ConfirmDialog subclass.

comment:8 Changed 7 years ago by freddefisk

By that logic, a confirm dialog is not needed at all since everything can be done with an ordinary Dialog. I thought the idea of such a component was to simplify common tasks like displaying a question with yes/no or yes/no/cancel options, displaying warning/error message, etc.

comment:9 Changed 7 years ago by bill

Right, my question is what the API would be (both programmatic and declarative), and whether adding any number of buttons with selectable labels to a ConfirmDialog would be easier (to the user) than adding those buttons to a plain Dialog. Obviously it's not just specifying the labels of the buttons, you need to specify different behavior for each button.

comment:10 Changed 7 years ago by bill

PS: default button is tracked in #6434.

comment:11 Changed 7 years ago by bill

Milestone: future1.10

comment:12 Changed 6 years ago by cjolif

bill you changed this from future to 1.10, does it mean you will handle it (in which case it should be assigned to you), if not I guess 1.10 milestone should be removed?

comment:13 Changed 6 years ago by bill

Milestone: 1.10future

comment:14 Changed 5 years ago by bill

Milestone: future1.10
Owner: set to bill
Status: newassigned
Type: enhancementfeature

comment:15 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In e3a9945cf96c08349939d448fd7e387d1e3a8773/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:16 Changed 5 years ago by Bill Keese <bill@…>

In 60c0f8fcbd760ad7f85d6b19087b71dae2977004/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.