Opened 8 years ago

Closed 8 years ago

#13277 closed defect (fixed)

build flag insertAbsMids fails when AMD module specifies an absolute module id

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Rawld Gill)

For example, 

define(
  "dojox/data/CsvStore", 
  ["dojo", "dojox", "dojo/data/util/filter", "dojo/data/util/simpleFetch"], 
  function(dojo, dojox) {

causes an extra absolute module id to be inserted when insertAbsMids is set truthy.

Change History (2)

comment:1 Changed 8 years ago by Rawld Gill

Description: modified (diff)
Status: new → assigned

While analyzing this issue, it seems that the insertAbsMids build flag should default to truthy if a v1x profile is being used since these kind of profiles tend to indicate non-AMD patterns such as including modules in script elements. Also, this is the way releases will be built.

comment:2 Changed 8 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

(In [25570]) fixed inserting absolute module ids in built AMD resources; changed build flag insertAbsMids default value to true if using a profile; fixes #13277; !strict

Note: See TracTickets for help on using tickets.