Opened 8 years ago

Closed 8 years ago

#13238 closed defect (fixed)

[patch] [ccla] methods should access dojo.doc.parentWindow not window/dojo.global

Reported by: bill Owned by: bill
Priority: high Milestone: 1.7
Component: HTML Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

(from Daniel Gurney, IBM)

I seem to be hitting a common theme when loading dojo in a child iframe but applying it to render in the main window, using dojo.setContext(). There are places in dojo where either the current window or dojo.global is used when really there needs to be a "ui window" property which is the dojo.doc.parentWindow, or dojo.doc.defaultView for Firefox, Safari, and Chrome.

See how sub-menus are rendered in attached example dijit/tests/test_UIWindowIssue_main.html.

  • dojo.window.getBox - returns a rect for the script window, and not the UI window.
  • dojo._docScroll returns scroll information for the script window, and not the UI window.

Attachments (1)

13238.patch​ (8.4 KB) - added by bill 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by bill

Attachment: 13238.patch​ added

comment:1 Changed 8 years ago by Eugene Lazutkin

(In [25705]) html: implemented the core part of the patch, thx Daniel Gurney, IBM!, !strict, refs #13238.

comment:2 Changed 8 years ago by Eugene Lazutkin

Milestone: tbd → 1.7
Owner: changed from Eugene Lazutkin to bill

Bill, please commit the Dijit part of the patch (tests), if you approve of them.

comment:3 Changed 8 years ago by bill

Resolution: → fixed
Status: new → closed

(In [25754]) Fix for when dojo is loaded into a separate frame, fixes #13238 !strict.

Note: See TracTickets for help on using tickets.