Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#13223 closed defect (fixed)

[patch] AMD refactoring for dojox.widget.Wizard to address i18n issues

Reported by: Kitson Kelly Owned by: dante
Priority: high Milestone: 1.7
Component: DojoX Widgets Version: 1.7.0b1
Keywords: patch Cc: ben hockey
Blocked By: Blocking:

Description

The attached patch (CCLA on file) refactors the dojox.widget.Wizard to support AMD, because with the i18n changes in 1.7b1 it no longer loaded its i18n properly. With AMD refactoring it appears to work.

Attachments (2)

Wizard.js.patch (1.3 KB) - added by Kitson Kelly 9 years ago.
Patch of dojox.widget.Wizard
Wizard.js.kgf.patch (4.8 KB) - added by Kenneth G. Franqueiro 8 years ago.
New patch for conversion to baseless AMD, with fix for test page

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by Kitson Kelly

Attachment: Wizard.js.patch added

Patch of dojox.widget.Wizard

comment:1 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [25604]) AMD updates, thanks kitsonk. Fixes #13223, refs #12863

comment:2 Changed 8 years ago by bill

Milestone: tbd1.7

comment:3 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: closedreopened

It seems like the patch for Wizard.js itself (the actual widget, not nls) was never applied/tested.

Moreover, Rice Yeh on the mailing list just pointed out a problem with the current module, since it no longer automatically pulls in _Templated as a transitive dependency. I'll check in a one-line fix for that, but we may want to look at this (non-baseless) AMD patch as well?

Last edited 8 years ago by Kenneth G. Franqueiro (previous) (diff)

comment:4 Changed 8 years ago by Kenneth G. Franqueiro

In [26764]:

Fix missing dependency in dojox/widget/Wizard, refs #13223 (see comment 3)

Changed 8 years ago by Kenneth G. Franqueiro

Attachment: Wizard.js.kgf.patch added

New patch for conversion to baseless AMD, with fix for test page

comment:5 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

In [26765]:

Fixes #13223, for real this time. Thanks for noticing, kgf

comment:6 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

warn(205) Module not tagged as pure AMD yet it contains AMD API applications. module: dojox/widget/Wizard

comment:7 Changed 8 years ago by Adam Peller

Cc: ben hockey added

Ben, where do we mark the modules as AMD?

comment:8 in reply to:  7 Changed 8 years ago by Kenneth G. Franqueiro

Replying to peller:

Ben, where do we mark the modules as AMD?

Ben can confirm/deny this, but my guess is we should take mention of Wizard out of line 33 of dojox/dojox.profile.js.

comment:9 Changed 8 years ago by ben hockey

yes - ensure that the profile.amd function in dojox.profile.js returns true when passed the filename for the dojox/widget/Wizard module. which is done by removing the reference to Wizard on line 33 as kgf said.

comment:10 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

In [26779]:

Fixes #13223 Wizard is now full AMD

comment:11 Changed 8 years ago by Chris Mitchell

In [26791]:

refs #13223 - cleanup AMD ref in Wizard \!strict

Note: See TracTickets for help on using tickets.