Opened 10 years ago
Closed 10 years ago
#13215 closed defect (fixed)
CSS problem in demo build
Reported by: | bill | Owned by: | Rawld Gill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | BuildSystem | Version: | 1.7.0b1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Doing a build like:
./build.sh copyTests=true mini=false action=clean,release profile=demos-all cssOptimize=comments.keepLines cssImportIgnore=../dijit.css
And then accessing the form demo:
demos/form/demo.html
It doesn't display correctly. Apparently dijit.css (which is loaded through tundra.css) didn't get loaded. Not sure why the demo fails and other demos work.
Change History (3)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Status: | new → assigned |
---|
doug is correct. The port of the v1.6- CSS optimizer (in util/build/transforms/optimizeCss.js) is improperly excluding CSS interning according to the cssImportIgnore directive while recursing through nested CSSs. In fact, cssImportIgnore can be applied only to @import's in a top-level CSS.
Also noted this error was showing up on other demos (e.g., mail).
Also noted jpg and gif files were not being copied as binary if transformed by read-write instead of copy. This can happens when a resource is tagged by something like "test" (e.g., dijit/tests/images).
comment:3 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I noticed that @import for dijit.css was positioned after some initial rules. The @import has to be before any rules (per css2 spec) so maybe that's causing it to be ignored.