#13206 closed defect (fixed)
[patch][ccla] dojo.store.Observable does not send correct put notification when the put object ID is 0
| Reported by: | cjolif | Owned by: | Kris Zyp |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Data | Version: | 1.7.0b1 |
| Keywords: | Cc: | Kris Zyp | |
| Blocked By: | Blocking: |
Description
See attached test case. When the id property of a data item is 0, the notification it has been modified is not correctly sent by Observable. More particularly the previousIndex attribute is set to -1 instead of the actual index of the element.
This comes from a test in Observable that test id existence this way:
if(existingId){..
while it should be:
if(existingId != undefined){
I have attached a patch that does this.
Attachments (2)
Change History (5)
Changed 10 years ago by
| Attachment: | dojo.store.Observable.id0.patch added |
|---|
comment:1 Changed 10 years ago by
| Owner: | changed from Jared Jurkiewicz to Kris Zyp |
|---|
comment:2 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 10 years ago by
| Milestone: | tbd → 1.7 |
|---|
Note: See
TracTickets for help on using
tickets.
patch