Opened 10 years ago
Closed 10 years ago
#13191 closed enhancement (fixed)
fixed dijit.form.Button label
Reported by: | gerhard presser | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Dijit - Form | Version: | 1.6.1 |
Keywords: | button label | Cc: | |
Blocked By: | Blocking: |
Description
if I extend dijit.form.Button and set an fixed label for this widget type, and create such widget via markup, the label is allways empty.
this happens because
dijit.form.Button._fillContent()
allways reads the source's innerHTML regardles if a label is allready set or the source has an innerHTML at all
I think the funktion should look something like:
_fillContent: function(/*DomNode*/ source){ if(source && source.innerHTML && (!this.params || !("label" in this.params))){ this.set('label', source.innerHTML); } },
Change History (3)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Milestone: | 1.6.2 → 1.7 |
---|---|
Status: | new → assigned |
comment:3 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Doesn't it already look like that? The latest code is: