Changes between Version 1 and Version 3 of Ticket #13190


Ignore:
Timestamp:
Jun 7, 2011, 4:57:00 PM (8 years ago)
Author:
ben hockey
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13190

    • Property Summary changed from dijit.CalendarLite - should _onMonthSelectbe using this._setCurrentFocusAttr to dijit.CalendarLite - should _onMonthSelect be using this._setCurrentFocusAttr
  • Ticket #13190 – Description

    v1 v3  
    1 `_onMonthSelect` assigns to `this.currentFocus` rather than calling `this._setCurrentFocusAttr`.  when the user changes month via `incrementMonth` or `decrementMonth` nodes, `this._setCurrentFocusAttr` is used.  the inconsistency means that a `watch` on `currentFocus` misses changes made via `_onMonthSelect`.  would it be ok to change `_onMonthSelect` to call `this._setCurrentFocus`?
     1`_onMonthSelect` assigns to `this.currentFocus` rather than calling `this._setCurrentFocusAttr`.  when the user changes month via `incrementMonth` or `decrementMonth` nodes, `this._setCurrentFocusAttr` is used.  the inconsistency means that a `watch` on `currentFocus` misses changes made via `_onMonthSelect`.  would it be ok to change `_onMonthSelect` to call `this._setCurrentFocusAttr`?
    22
    33the code is only used by dijit.Calendar with the dropdown for the month.  maybe the function could also move to dijit.Calendar