Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#13190 closed defect (fixed)

dijit.CalendarLite - should _onMonthSelect be using this._setCurrentFocusAttr

Reported by: ben hockey Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by ben hockey)

_onMonthSelect assigns to this.currentFocus rather than calling this._setCurrentFocusAttr. when the user changes month via incrementMonth or decrementMonth nodes, this._setCurrentFocusAttr is used. the inconsistency means that a watch on currentFocus misses changes made via _onMonthSelect. would it be ok to change _onMonthSelect to call this._setCurrentFocusAttr?

the code is only used by dijit.Calendar with the dropdown for the month. maybe the function could also move to dijit.Calendar

Change History (6)

comment:1 Changed 9 years ago by ben hockey

Description: modified (diff)

comment:2 Changed 9 years ago by ben hockey

Summary: dijit.CalendarLite - should _onMonthSelectbe using this._setCurrentFocusAttrdijit.CalendarLite - should _onMonthSelect be using this._setCurrentFocusAttr

comment:3 Changed 9 years ago by ben hockey

Description: modified (diff)

comment:4 Changed 9 years ago by Douglas Hays

Owner: set to bill

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [25480]) make month selection from drop down generate watch() notification for currentFocus attribute, fixes #13190 !strict

comment:6 Changed 9 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.