[patch][ccla]dijit.form.ExpandingTextAreaMixin.resize might compute negative height throwing error under IE

[Patrick Ruzand]

The issue is specific to IE, and happens when the TextArea? resize() is triggered. In some situation, the height value that is assigned to "textarea.style.height" can be negative, throwing an "invalid argument" error :

in dijit/form/_ExpandingTextAreaMixin.js, l.89 :

var currentHeight = textarea.style.height; if(!(/px/.test(currentHeight))){ [...] } var newH = parseInt(currentHeight) + textareaScrollHeight() -

textarea.clientHeight;

var newHpx = newH + "px"; if(newHpx != textarea.style.height){

textarea.rows = 1; textarea.style.height = newHpx; <<<<<<< error if newHpx is < 0

}

In my use case, the computed newH value is < 0, which gives the exception. I would say 'newH' should be checked against negative value.

[Patrick Ruzand]

testcase + patch

[Douglas Hays]

While this prevents an exception, it does 2 bad things:
1) hides the fact that the web page needs to change to SimpleTextarea? since Textarea "owns" height
2) causes the textarea to be chopped off and scrollbars to appear

[Douglas Hays]

Setting minHeight in IE8 is also causing an exception

[Douglas Hays]

fix + testcase

[Douglas Hays]

(In [25465]) Fixes #13166. Check to make sure that height is not set to less than the scrollHeight. Added automated testcase.