[regression] dojo.dnd.Movable.onMouseUp needs to disconnect more events

[JIm Fulton]

dojo.dnd.Movable.onMouseUp almost certainly needs to disconnect 4, rather than 2 events. I assume that the touch event handler registrations were added to onMouseDown after onMouseUp was written.

The bug is in svn as well as 1.6.1.

[bill]

I must have broke this w/my patch to add touch support to DnD.

Probably would be fixed in trunk by checking in the DnD patch from #12934. Although seems safer to also use Eugene's recently suggested

while(this.events.length){
	dojo.disconnect(this.events.pop());
}

syntax in all cases anyway. Especially the 1.6 branch, where dojo.touch is not available.

[JIm Fulton]

That while loop doesn't look right to me. It would disconnect handlers set up in the constructor. Maybe the while loop makes more sense in light of other patches.

[bill]

Ah you are right. Anyway should apply the patch in #12934, and then 2 will be the right number again. (And if we want to fix for the 1.6/ branch, change 2 to 4 like you said originally.)

[bill]

(In [25666]) Use dojo.touch code in dojo.dnd, fixes #12934, #13135. (I checked w/Eugene, he said Evan's patch looked good.)