Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13109 closed defect (fixed)

BorderContainer: dijitAlignLeft selector for overflow:hidden should not override ContentPane overflow

Reported by: Nick Fenwick Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.6.0
Keywords: dijitalignleft, contentpane, overflow Cc:
Blocked By: Blocking:

Description

wildbill confirmed on #dojo IRC that there's a bug in the way a ContentPane? has its overflow set to hidden when put in a leading (or trailing, or ...?) region of a BorderContainer?.

A sandbox that demonstrates the effect: http://dojo-sandbox.net/public/085cf/0

Seems to affect 1.6.0 and 1.6.1.

Workaround is to force the ContentPane? to have overflow:visible (or auto, I guess..).

<wildbill> neekfenwick: you are right, there's a bug there, if you file a ticket i can fix. i guess that the selector for dijitAlignLeft etc. shouldn't be overriding the selector dijitContentPane. <wildbill> the selector for the dijitalignleft class dates back to http://bugs.dojotoolkit.org/changeset/8376#file5

Change History (4)

comment:1 Changed 8 years ago by Nick Fenwick

My hacky way of getting around this is to put:

/* BUG http://bugs.dojotoolkit.org/ticket/13109 */ body .dijitContentPane .dijitAlignTop, body .dijitContentPane .dijitAlignBottom, body .dijitContentPane .dijitAlignLeft, body .dijitContentPane .dijitAlignRight {

overflow: auto !important;

}

in my css, loaded after the dijit css.

comment:2 Changed 8 years ago by bill

Milestone: 1.6.21.7
Owner: set to bill
Status: newassigned
Summary: dijitAlignLeft selector for overflow:hidden should not override ContentPane overflowBorderContainer: dijitAlignLeft selector for overflow:hidden should not override ContentPane overflow

Not expecting a 1.6.2 but I'll fix for 1.7.

comment:3 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [25262]) Don't let .dijitAlignLeft overflow:hidden override .dijitContentPane's overflow:auto. Fixes #13109 !strict.

comment:4 Changed 8 years ago by Nick Fenwick

Just to mention, my hacky fix above is no good, we're far better off hot patching 1.6.x with Bill's fix in [25262].

Note: See TracTickets for help on using tickets.