Opened 8 years ago

Closed 5 years ago

#13108 closed enhancement (patchwelcome)

can't exit full screen mode while in view source mode

Reported by: bill Owned by: Jared Jurkiewicz
Priority: low Milestone: future
Component: Editor Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

In test_ViewSource.html:

  1. on second editor, press button to enter full screen mode
  2. press button to view source
  3. press full screen button again (to leave full screen mode)

It should revert to normal size, but there's no effect.

Change History (5)

comment:1 Changed 8 years ago by Jared Jurkiewicz

Resolution: → invalid
Status: new → closed

This is intentional. When it goes into view source mode, all plugins/modes/etc are disabled. If you absolutely insist, I will look at changing this behavior, but as it currently stands, this is intentional.

comment:2 Changed 8 years ago by bill

Type: defect → enhancement

Ah OK thanks, didn't realize that. I don't need that functionality.

I guess I got confused by the _resize() method in ViewSource.js, what's that for?

comment:3 Changed 8 years ago by Jared Jurkiewicz

Resolution: invalid
Status: closed → reopened

The resize is used when you're in fullscreen mode (or generally if editor itself is resized, it has to resize if the editor resizes.

As for not disabling it, the plugin would have to know about each other, which I guess is okay

comment:4 Changed 8 years ago by Jared Jurkiewicz

Milestone: tbd → future
Priority: normal → low

comment:5 Changed 5 years ago by bill

Resolution: → patchwelcome
Status: reopened → closed

Unlikely this will be fixed unless someone wants to supply a patch (including a test case).

Note: See TracTickets for help on using tickets.