Opened 8 years ago

Closed 8 years ago

#13107 closed enhancement (fixed)

make dojo._getMarginSize() public?

Reported by: bill Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: HTML Version: 1.6.1
Keywords: Cc: Shane O'Sullivan
Blocked By: Blocking:

Description

See #11622 for explanation. Assuming you buy the explanation in the ticket, _getMarginSize() should be a public function. The alternative is to replace all usages with dojo.marginBox().

Change History (7)

comment:1 Changed 8 years ago by bill

(In [25253]) dojo._getBorderBox() was removed in html.js refactor. Use dojo.position() instead.

Also, replace unnecessary use of private dojo._getMarginSize() with dojo.position().

Refs #9641, #11622, #13107 !strict.

comment:2 Changed 8 years ago by bill

(In [25254]) Replace unnecessary use of private dojo._getMarginSize() with dojo.position(). Refs #9641, #11622, #13107 !strict.

comment:3 Changed 8 years ago by Eugene Lazutkin

Milestone: tbd1.7
Resolution: fixed
Status: newclosed

Done in [25704] of #9641.

comment:4 Changed 8 years ago by Eugene Lazutkin

Resolution: fixed
Status: closedreopened

No, Bill, you request has to wait. It was reverted in [25745].

comment:5 Changed 8 years ago by bill

Milestone: 1.71.8

IIRC correctly we said to do these in 1.8? In any case, milestone shouldn't be marked as 1.7.

comment:6 Changed 8 years ago by Eugene Lazutkin

It looks like all requested changes are in Dojo Base already. Are we good to close these tickets?

comment:7 Changed 8 years ago by bill

Milestone: 1.81.7
Resolution: fixed
Status: reopenedclosed

Agreed, it's in [25901].

Note: See TracTickets for help on using tickets.