Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13100 closed feature (fixed)

MultiSelect: control over base text direction (textDir)

Reported by: tomerm Owned by: bill
Priority: high Milestone: 1.8
Component: Dijit - Form Version: 1.6.1
Keywords: bidi Cc: MARIAVIN@…, Douglas Hays
Blocked By: Blocking:

Description (last modified by bill)

The core support for base text direction (via textDir) was introduced in #12367.

This ticket addresses control over base text direction in dijit.form.MultiSelect control.

The solution involves wrapping the <option> text by UCC (Unicode control character), since some browsers e.g. IE8 and Opera11.10, completely ignore the dir attribute in <option> tag (in FF3.6 there's alignment problems). Therefore we can't just set option's dir following the textDir. Lack of support for dir on the <option> level is a known issue:

Attachments (1)

patch201105231345_Dojo-textDirMultiSelect.txt (17.9 KB) - added by bill 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by Adam Peller

Component: GeneralDijit
Keywords: bidi added

comment:2 Changed 8 years ago by bill

Cc: Douglas Hays added; doughays@… bill@… removed
Component: DijitDijit - Form
Description: modified (diff)
Owner: set to bill
Status: newassigned
Summary: Control over base text direction (textDir) for dijit.MultiSelectMultiSelect: control over base text direction (textDir)
Type: defectfeature

I'll check this in since I did the review with Maria. We're not supporting FF3.6 anymore but of course, we do need to support IE8.

Last edited 8 years ago by bill (previous) (diff)

comment:3 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [27688]:

Support textdir for MultiSelect, patch from Maria Vinikov (IBM, CCLA), thanks! Fixes #13100 !strict.

I do think eventually though that we should replace MultiSelect altogether with a friendly widget, like dojox.form.CheckedMultiSelect.

comment:4 Changed 8 years ago by bill

In [27689]:

Remove stray reference to dojo global. Clone() call is not necessary here at all. Refs #13100 !strict.

Note: See TracTickets for help on using tickets.