#13092 closed defect (fixed)
[patch][ccla] the gfx surface is not clipped under IE9/svg
Reported by: | Patrick Ruzand | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.5.2 |
Component: | DojoX GFX | Version: | 1.6.1 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
When a page is rendered in standard mode, the svg surface does not clip under IE9, as opposed to the Chrome/FF. In fact, IE9 is (to my understanding) correct wrt the SVG spec:
from: http://www.w3.org/TR/SVG/masking.html#OverflowProperty
"The initial value for ‘overflow’ as defined in [CSS2-overflow] is 'visible', and this applies also to the root ‘svg’ element;"
Fix: explicitely set the surface rawNode overflow attribute to 'hidden' when the surface is created.
Attachments (1)
Change History (9)
Changed 10 years ago by
Attachment: | 13092.patch added |
---|
comment:1 Changed 10 years ago by
Summary: | the gfx surface is not clipped under IE9/svg → [patch][ccla] the gfx surface is not clipped under IE9/svg |
---|
comment:2 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
comment:5 Changed 10 years ago by
Heh, it looks like both chrism and I tried to commit the patch: [25219].
I had to reformat the patch:
- Please follow the style guide.
- Please use "" quotes consistently, use only if you have to. And try not to mix both, if it is possible. I bet it was possible in this case.
- Don't do multiple spaces in a row unless you want to align something to improve readability.
- Make sure that text corresponds to code --- it was "Testing arc", so I was looking for it, instead it was a clipped rectangle.
- Even in HTML try to show the structure.
Other than that it was an excellent patch: small, practical, low-risk.
comment:6 Changed 10 years ago by
In the point 2 above it should be double quotes vs. single quotes. The latter got interpreted as "switch to italic".
comment:7 Changed 10 years ago by
Yeah, forgot to say that when we glue words together (in identifiers, or file names) we usually use a camel case nowadays.
In general I found that mimicking a surrounding code is a good rule of thumb --- improves readability. Otherwise it'll look like a patchwork. So if in doubt --- look around.
comment:8 Changed 9 years ago by
Milestone: | 1.7 → 1.5.2 |
---|
patch + test case