Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13092 closed defect (fixed)

[patch][ccla] the gfx surface is not clipped under IE9/svg

Reported by: Patrick Ruzand Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5.2
Component: DojoX GFX Version: 1.6.1
Keywords: Cc: pruzand@…
Blocked By: Blocking:

Description

When a page is rendered in standard mode, the svg surface does not clip under IE9, as opposed to the Chrome/FF. In fact, IE9 is (to my understanding) correct wrt the SVG spec:

from: http://www.w3.org/TR/SVG/masking.html#OverflowProperty

"The initial value for ‘overflow’ as defined in [CSS2-overflow] is 'visible', and this applies also to the root ‘svg’ element;"

Fix: explicitely set the surface rawNode overflow attribute to 'hidden' when the surface is created.

Attachments (1)

13092.patch (1.8 KB) - added by Patrick Ruzand 8 years ago.
patch + test case

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Patrick Ruzand

Attachment: 13092.patch added

patch + test case

comment:1 Changed 8 years ago by Chris Mitchell

Summary: the gfx surface is not clipped under IE9/svg[patch][ccla] the gfx surface is not clipped under IE9/svg

comment:2 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [25216]) fixes #13092 initial overflow for svg should default to hidden on Surface to fix clipping bug on ie9 \!strict

comment:3 Changed 8 years ago by Chris Mitchell

(In [25217]) fixes #13092 initial overflow for svg should default to hidden on Surface to fix clipping bug on ie9 \!strict

comment:4 Changed 8 years ago by Chris Mitchell

(In [25218]) refs #13092 updated testcase text for surface clipping\!strict

comment:5 Changed 8 years ago by Eugene Lazutkin

Heh, it looks like both chrism and I tried to commit the patch: [25219].

I had to reformat the patch:

  1. Please follow the style guide.
  2. Please use "" quotes consistently, use only if you have to. And try not to mix both, if it is possible. I bet it was possible in this case.
  3. Don't do multiple spaces in a row unless you want to align something to improve readability.
  4. Make sure that text corresponds to code --- it was "Testing arc", so I was looking for it, instead it was a clipped rectangle.
  5. Even in HTML try to show the structure.

Other than that it was an excellent patch: small, practical, low-risk.

comment:6 Changed 8 years ago by Eugene Lazutkin

In the point 2 above it should be double quotes vs. single quotes. The latter got interpreted as "switch to italic".

comment:7 Changed 8 years ago by Eugene Lazutkin

Yeah, forgot to say that when we glue words together (in identifiers, or file names) we usually use a camel case nowadays.

In general I found that mimicking a surrounding code is a good rule of thumb --- improves readability. Otherwise it'll look like a patchwork. So if in doubt --- look around.

comment:8 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: 1.71.5.2

Updating milestone to 1.5.2 to reflect inclusion in changeset [26956] for ticket #14199.

Note: See TracTickets for help on using tickets.