Opened 11 years ago
Closed 11 years ago
#13089 closed defect (fixed)
[patch][ccla] modify charting tests to not use compatibility mode on IE9 so that SVG is used
| Reported by: | cjolif | Owned by: | Eugene Lazutkin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Charting | Version: | 1.6.1 |
| Keywords: | Cc: | [email protected]…, [email protected]… | |
| Blocked By: | Blocking: |
Description
This patch is a batch modification of all charting tests to not use IE compatibility mode on IE9 so that GFX relies on SVG not VML.
This uses this trick to trigger the compatibility only when needed:
<!--[if IE 8]>
<!DOCTYPE>
<html lang="en">
<head>
<meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7"/>
<![endif]-->
<![if !(IE 8)]>
<!DOCTYPE>
<html lang="en">
<head>
<![endif]>
Attachments (1)
Change History (9)
Changed 11 years ago by
| Attachment: | dojox.charting.ie9.test.patch added |
|---|
comment:1 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 11 years ago by
Now if we could find a similar hack to fix doctype for safari5 so that gradients always work...
comment:3 Changed 11 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Yeah, the hack for Safari is to make sure that non-IE browsers get <!DOCTYPE HTML>. The "HTML" part is the needed thing. Gonna reopen the ticket just so we know what's going on.
comment:4 Changed 11 years ago by
I think this can be solved that way:
<!--[if IE 7]>
<!DOCTYPE>
<html lang="en">
<head>
<![endif]-->
<!--[if IE 8]>
<!DOCTYPE>
<html lang="en">
<head>
<meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7"/>
<![endif]-->
<![if gte IE 9]>
<!DOCTYPE HTML>
<html lang="en">
<head>
<![endif]>
If there is no objection I'll fix this.
comment:5 Changed 11 years ago by
While you're at it, can you fix the non-IE branches so that it's <!DOCTYPE HTML>, so that gradients in Safari are no longer borked? Thanks!
comment:6 Changed 11 years ago by
The last section applies to both IE9+ _and_ other browsers that don't interpret IE conditional meta comments. So that solves Safari issue.
comment:7 Changed 11 years ago by
Yeah, if and only if the non-branch works. Granted I haven't looked at it in a week or so but I seem to remember the majority of tests in /charting/tests having <!DOCTYPE> only; if you're touching them, please make sure it is <!DOCTYPE HTML> for non-IE browsers.
(In [25214]) fixes #13089 updated charting tests to work with IE8/9 properly