Opened 8 years ago

Closed 4 years ago

#13070 closed defect (patchwelcome)

dojox.form.uploader.plugins.Flash given URL cannot include several parameters

Reported by: Matias Rask Owned by: dylan
Priority: high Milestone: 1.11
Component: DojoX Uploader Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

dojox.form.uploader.plugins.Flash From line 238

_createFlashUploader: function(){
	// summary:
	//		Internal. Creates Flash Uploader
	//
	var url = this.getUrl();
	if(url){
		if(url.toLowerCase().indexOf("http")<0 && url.indexOf("/")!=0){
			// Appears to be a relative path. Attempt to
			//	convert it to absolute, so it will better
			//target the SWF.
			//
			var loc = window.location.href.split("/");
			loc.pop();
			loc = loc.join("/")+"/";
			url = loc+url;
		}
	}else{
		console.warn("Warning: no uploadUrl provided.");
	}

Should include

url = encodeURIComponent(url);

Change History (3)

comment:1 Changed 7 years ago by bill

Component: GeneralDojoX Uploader
Owner: set to Mike Wilcox

comment:2 Changed 4 years ago by dylan

Owner: changed from Mike Wilcox to dylan
Status: newassigned

comment:3 Changed 4 years ago by dylan

Milestone: tbd1.11
Resolution: patchwelcome
Status: assignedclosed

My apologies that this was ignored for so many years.

Given that flash is quickly being abandoned as something that runs by default on the web, I'm going to mark this as patchwelcome. I know there's a patch. If you want to recreate as a pull request via github following the guidelines at ​https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md , we'll review and land it.

Note: See TracTickets for help on using tickets.