Opened 6 years ago

Closed 21 months ago

#13070 closed defect (patchwelcome)

dojox.form.uploader.plugins.Flash given URL cannot include several parameters

Reported by: mathewrapid Owned by: dylan
Priority: high Milestone: 1.11
Component: DojoX Uploader Version: 1.6.1
Keywords: Cc:
Blocked by: Blocking:

Description

dojox.form.uploader.plugins.Flash From line 238 

_createFlashUploader: function(){
	// summary:
	//		Internal. Creates Flash Uploader
	//
	var url = this.getUrl();
	if(url){
		if(url.toLowerCase().indexOf("http")<0 && url.indexOf("/")!=0){
			// Appears to be a relative path. Attempt to
			//	convert it to absolute, so it will better
			//target the SWF.
			//
			var loc = window.location.href.split("/");
			loc.pop();
			loc = loc.join("/")+"/";
			url = loc+url;
		}
	}else{
		console.warn("Warning: no uploadUrl provided.");
	}

Should include 

url = encodeURIComponent(url);

Change History (3)

comment:1 Changed 5 years ago by bill

  • Component changed from General to DojoX Uploader
  • Owner set to mwilcox

comment:2 Changed 21 months ago by dylan

  • Owner changed from mwilcox to dylan
  • Status changed from new to assigned

comment:3 Changed 21 months ago by dylan

  • Milestone changed from tbd to 1.11
  • Resolution set to patchwelcome
  • Status changed from assigned to closed

My apologies that this was ignored for so many years.

Given that flash is quickly being abandoned as something that runs by default on the web, I'm going to mark this as patchwelcome. I know there's a patch. If you want to recreate as a pull request via github following the guidelines at ​​https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md , we'll review and land it.

Note: See TracTickets for help on using tickets.