Opened 8 years ago

Closed 8 years ago

#13061 closed defect (fixed)

EDG pagination - incomplete data displayed when switching page size

Reported by: evan Owned by: evan
Priority: high Milestone: 1.7
Component: DojoX Grid Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Steps to reproduce:

  1. run the attached test case
  2. switch page size by clicking 50 or 100

Only part of data are displayed

Attachments (1)

13061.html​ (5.0 KB) - added by evan 8 years ago.
By running under dojox/grid/tests/enhanced/

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by evan

Attachment: 13061.html​ added

By running under dojox/grid/tests/enhanced/

comment:1 Changed 8 years ago by evan

Resolution: → fixed
Status: new → closed

(In [25164]) Fixes #13061 !strict should showAll when total row size < page size, also backport to 1.6 branch

comment:2 Changed 8 years ago by manklu

Resolution: fixed
Status: closed → reopened

Suggestion for another (better?) solution.

Instead of changing 'showAll' remove the statement: 

this.grid.rowsPerPage = this.defaultRows;

It seem to work and doesn't affect code which depend on 'showAll'.

comment:3 Changed 8 years ago by evan

Resolution: → fixed
Status: reopened → closed

Thanks manklu,

this.grid.rowsPerPage = this.defaultRows;

Is supposed to avoid a possible performance issue when user choose All(suppose we have 1000 rows in total), then in the All mode, we shall use the default rowsPerPage parameter so that we don't have to render all the 1000 rows, instead use the virtual scrolling way.

BTW, defaultRows is really not intuitive, better to be _defaultRowsPerPage(changed with [25408]), it simply back up the initial rowsPerPage option.

Note: See TracTickets for help on using tickets.