Opened 10 years ago

Closed 10 years ago

#13050 closed enhancement (fixed)

build application should intern dojo.cache strings

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

As of v1.7, the approved method of interning strings is by including the string resource as a dojo/text! resource in the module's dependencies. For example, see all dijit templates.

For legacy v1.x code, the build application should attempt to intern text resources referenced with dojo.cache.

Change History (8)

comment:1 Changed 10 years ago by Rawld Gill

Status: newassigned

comment:2 Changed 10 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

(In [25375]) added machinery to intern dojo.cache strings; fixes #13050; !strict

comment:3 Changed 10 years ago by Rawld Gill

This repair also adds support for interning templatePath.

Support for templateCssPath has been removed.

This machinery is taken from the v1.6- build app and uses fragile regexs. Behavior will be no better or worse than 1.6-.

comment:4 Changed 10 years ago by dante

Resolution: fixed
Status: closedreopened

It doesn't appear to be interning everything? I made a sample case, and the module isn't reported in the "interning strings for ..." list. I was also getting an error running the build after updating to this revision on a module used for dojocampus, with the error

there is no method getText in [object Object]

at line 158 of build/transforms/scanDeps.js

comment:5 Changed 10 years ago by Rawld Gill

Status: reopenednew

comment:6 Changed 10 years ago by Rawld Gill

Status: newassigned

comment:7 Changed 10 years ago by Rawld Gill

(In [25477]) improved string interning to handle resources that don't include a getText method; refs #13050; !strict

comment:8 Changed 10 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

fixed in [25477]

Note: See TracTickets for help on using tickets.