Opened 8 years ago

Closed 3 years ago

#13036 closed defect (fixed)

[meta] lint fixes

Reported by: bill Owned by:
Priority: high Milestone: 1.11
Component: General Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Meta ticket for lint fixes such as:

  • missing semicolons
  • unneeded return/continue statement
  • if() branches that can be converted to ternary or simple assignments
  • unneeded/unused local variables
  • unwanted globals

etc.

Change History (39)

comment:1 Changed 8 years ago by bill

(In [25105]) missing semicolons plus a few spacing fixes, refs #7390 !strict

comment:2 Changed 8 years ago by bill

(In [25108]) unneeded return/continue statements, simplification of if()'s, etc., refs #13036 !strict

comment:3 Changed 8 years ago by bill

(In [25109]) removing unneeded variables, refs #13036 !strict

comment:4 Changed 8 years ago by bill

(In [25110]) remove unwanted semicolons, refs #13036 !strict

comment:5 Changed 8 years ago by bill

(In [25111]) remove unsued variables and unused (local) functions, refs #13036 !strict

comment:6 Changed 8 years ago by bill

(In [25112]) fixing accidental globals, refs #13036 !strict

comment:7 Changed 8 years ago by bill

(In [25114]) Removing unreachable code, although this file is just for documentation so it doesn't really matter. The return value can be specified in the API comment (returns: ...) although since I didn't bother when it was already described in the summary. Refs #13036 !strict

comment:8 Changed 8 years ago by bill

(In [25115]) a few more lint fixes for core, refs #13036 !strict

comment:9 Changed 8 years ago by bill

(In [25119]) missing semicolons and spacing fixes, refs #13036 !strict

comment:10 Changed 8 years ago by bill

(In [25121]) simplifying expressions, removing unneeded return statements and variables, refs #13036 !strict

comment:11 Changed 8 years ago by bill

(In [25122]) fixing CSS syntax errors, removing needless "px" in "0px" expressions, fixing file paths, refs #13036 !strict

comment:12 Changed 8 years ago by bill

(In [25123]) missing semicolons and spacing fix, refs #13036 !strict

comment:13 Changed 8 years ago by bill

(In [25972]) Lint fixes in dijit for:

  • unterminated statements
  • duplicate declarations (including an entire duplicated function)
  • unnecessary semicolons
  • remove unused variables and intermediate variables

Refs #13036 !strict

comment:14 Changed 8 years ago by bill

In [26065]:

Avoid warnings about unused parameters. When the parameter exists for API documentation reasons, surround with /*===== =====*/.

Refs #13036 !strict.

comment:15 Changed 8 years ago by bill

In [26141]:

lint fixes and removing unused / duplicate variables, refs #13036 !strict

comment:16 Changed 8 years ago by bill

In [26199]:

avoid warning about unused variables, refs #13036 !strict

comment:17 Changed 8 years ago by bill

In [26209]:

fix missing semicolons, unused variables, braceless if() statements, spelling, stray global, refs #13036 !strict

comment:18 Changed 7 years ago by bill

In [27188]:

fix indentation, refs #13036 !strict

comment:19 Changed 7 years ago by bill

In [27360]:

fix spacing, refs #13036 !strict

comment:20 Changed 7 years ago by bill

In [27361]:

more lint fixes, plus fix of apparent typo in mysterious "group-test-type-up" function, refs #13036 !strict

comment:21 Changed 7 years ago by bill

In [27561]:

enable accidentally disabled test, and fix lint errors, refs #13036

comment:22 Changed 7 years ago by bill

In [27563]:

fix lint errors, refs #13036 !strict

comment:23 Changed 7 years ago by bill

In [27568]:

index is apparently a reserved word, so use idx instead, refs #13036 !strict

comment:24 Changed 7 years ago by bill

In [27569]:

fix invalid HTML and other lint errors, refs #13036 !strict

comment:25 Changed 7 years ago by bill

In [27790]:

fix spacing, refs #13036 !strict

comment:26 Changed 7 years ago by bill

In [27870]:

Change index-->idx in GreekPalette, to match change in _PaletteMixin, fixes #14790, refs #13036 !strict.

comment:27 Changed 7 years ago by bill

In [27884]:

Fix trailing commas, refs #13036 !strict.

comment:28 Changed 7 years ago by bill

In [27885]:

Empty comment seems to confuse closure, plus fixing indentation, refs #13036 !strict.

comment:29 Changed 7 years ago by bill

In [27886]:

"class" is a reserved word (or will be eventuallly), and removing apparent mistaken "new" keyword. Refs #13036 !strict.

comment:30 Changed 7 years ago by bill

In [28347]:

missing semicolon, refs #13036 !strict

comment:31 Changed 7 years ago by bill

In [28503]:

comma should be semicolon, refs #13036 !strict

comment:32 Changed 7 years ago by bill

In [28660]:

missing semicolons and fix indentation, refs #13036

comment:33 Changed 7 years ago by bill

In [28675]:

missing semicolons, refs #13036 !strict

comment:34 Changed 7 years ago by bill

In [28810]:

dojox/geo: Fixing code to conform to Dojo coding standards: no spaces for if(), else, etc., braces for all if() and else statements, no spaces before colons, removing spaces at ends of lines, etc.

Also some more doc comment fixes, mainly removing duplicate type declarations for parameters


Refs #13036, #13101 !strict.

comment:35 Changed 7 years ago by bill

In [28900]:

spacing fixes, refs #13036 !strict

comment:36 Changed 7 years ago by bill

In [29428]:

fix syntax errors in demos, refs #13036 !strict

comment:37 Changed 7 years ago by bill

#9534 is a duplicate of this ticket.

comment:38 Changed 6 years ago by bill

In [30090]:

fix spelling and a few lint errors, refs #13036 !strict

comment:39 Changed 3 years ago by dylan

Milestone: tbd1.11
Resolution: fixed
Status: newclosed

This meta ticket has been inactive for 3+ years. Closing it out.

Note: See TracTickets for help on using tickets.