[meta] lint fixes

[bill]

Meta ticket for lint fixes such as:

• missing semicolons
• unneeded return/continue statement
• if() branches that can be converted to ternary or simple assignments
• unneeded/unused local variables
• unwanted globals

etc.

[bill]

(In [25105]) missing semicolons plus a few spacing fixes, refs #7390 !strict

[bill]

(In [25108]) unneeded return/continue statements, simplification of if()'s, etc., refs #13036 !strict

[bill]

(In [25109]) removing unneeded variables, refs #13036 !strict

[bill]

(In [25110]) remove unwanted semicolons, refs #13036 !strict

[bill]

(In [25111]) remove unsued variables and unused (local) functions, refs #13036 !strict

[bill]

(In [25112]) fixing accidental globals, refs #13036 !strict

[bill]

(In [25114]) Removing unreachable code, although this file is just for documentation so it doesn't really matter. The return value can be specified in the API comment (returns: ...) although since I didn't bother when it was already described in the summary. Refs #13036 !strict

[bill]

(In [25115]) a few more lint fixes for core, refs #13036 !strict

[bill]

(In [25119]) missing semicolons and spacing fixes, refs #13036 !strict

[bill]

(In [25121]) simplifying expressions, removing unneeded return statements and variables, refs #13036 !strict

[bill]

(In [25122]) fixing CSS syntax errors, removing needless "px" in "0px" expressions, fixing file paths, refs #13036 !strict

[bill]

(In [25123]) missing semicolons and spacing fix, refs #13036 !strict

[bill]

(In [25972]) Lint fixes in dijit for:

• unterminated statements
• duplicate declarations (including an entire duplicated function)
• unnecessary semicolons
• remove unused variables and intermediate variables

Refs #13036 !strict

[bill]

In [26065]:

Avoid warnings about unused parameters. When the parameter exists for API documentation reasons, surround with /*===== =====*/.

Refs #13036 !strict.

[bill]

In [26141]:

lint fixes and removing unused / duplicate variables, refs #13036 !strict

[bill]

In [26199]:

avoid warning about unused variables, refs #13036 !strict

[bill]

In [26209]:

fix missing semicolons, unused variables, braceless if() statements, spelling, stray global, refs #13036 !strict

[bill]

In [27188]:

fix indentation, refs #13036 !strict

[bill]

In [27360]:

fix spacing, refs #13036 !strict

[bill]

In [27361]:

more lint fixes, plus fix of apparent typo in mysterious "group-test-type-up" function, refs #13036 !strict

[bill]

In [27561]:

enable accidentally disabled test, and fix lint errors, refs #13036

[bill]

In [27563]:

fix lint errors, refs #13036 !strict

[bill]

In [27568]:

index is apparently a reserved word, so use idx instead, refs #13036 !strict

[bill]

In [27569]:

fix invalid HTML and other lint errors, refs #13036 !strict

[bill]

In [27790]:

fix spacing, refs #13036 !strict

[bill]

In [27870]:

Change index-->idx in GreekPalette, to match change in _PaletteMixin, fixes #14790, refs #13036 !strict.

[bill]

In [27884]:

Fix trailing commas, refs #13036 !strict.

[bill]

In [27885]:

Empty comment seems to confuse closure, plus fixing indentation, refs #13036 !strict.

[bill]

In [27886]:

"class" is a reserved word (or will be eventuallly), and removing apparent mistaken "new" keyword. Refs #13036 !strict.

[bill]

In [28347]:

missing semicolon, refs #13036 !strict

[bill]

In [28503]:

comma should be semicolon, refs #13036 !strict

[bill]

In [28660]:

missing semicolons and fix indentation, refs #13036

[bill]

In [28675]:

missing semicolons, refs #13036 !strict

[bill]

In [28810]:

dojox/geo: Fixing code to conform to Dojo coding standards: no spaces for if(), else, etc., braces for all if() and else statements, no spaces before colons, removing spaces at ends of lines, etc.

Also some more doc comment fixes, mainly removing duplicate type declarations for parameters

Refs #13036, #13101 !strict.

[bill]

In [28900]:

spacing fixes, refs #13036 !strict

[bill]

In [29428]:

fix syntax errors in demos, refs #13036 !strict

[bill]

#9534 is a duplicate of this ticket.

[bill]

In [30090]:

fix spelling and a few lint errors, refs #13036 !strict

[dylan]

This meta ticket has been inactive for 3+ years. Closing it out.