[25087] change on dojo.parser breaks a typical usage of dojo.extend

[evan]

Just noticed [25087] breaks all Grid testing files and was able to narrow down the cause, the following line change caused the issue:
dojo.parser.js line 48

aspect.after(dlang, "extend", function(){
    _nameMap = {};
});

Change it back to

dojo.connect(dlang, "extend", function(){
    _nameMap = {};
});

makes things work well.

More specifically, the new change caused the following usage of dojo.extend not working anymore(which was used in dojox.grid._Builder.js)

var clz = dojo.extend(function(view){
	this.v1 = 'v1';
	this.v2 = 'v2';
	this.v_1 = 'v_1';
},{
	v_1: "v1",
	v_2: "v2",
	f_1: function(){
		console.log('f_1')
	}
});
console.log(clz);

clz will be undefined with the new change

[evan]

The test case to reproduce the issue, pls run it under dojo/tests/

[evan]

A small patch fixes the issue(at least to make all Grid test cases run well)

[bill]

Oh, sorry about that. It's bizarre since those two commands should do exactly the same thing. (BTW dojo/_base/connect is not being required by the parser so it's dangerous to use it.) Anyway I'll take a look.

[bill]

PS: the tests seem to work fine for me. Even test_grid.html is failing for you? Which browser did you test on?

[bill]

Oh, nevermind, I see it, it's a question of the return value from dojo.extend(). I'll fix it.

[bill]

(In [25104]) Use true arg to aspect.after() so my handler doesn't affect the return value of the original function. Refs #12432, fixes #13033 !strict. Also fixing a missing require in grid test file.

[evan]

Thanks, Bill, working perfect now.