Opened 8 years ago

Closed 7 years ago

#12998 closed defect (patchwelcome)

Grid destroys tab order

Reported by: manklu Owned by: Evan
Priority: high Milestone: future
Component: DojoX Grid Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

There are several elements which have a fixed tabindex of zero, which has catastrophic results if the tabindex of the grid is not zero.

If they can't use -1, they should use the value of the grid.

Attachments (2)

test_issue_12998.html (5.7 KB) - added by manklu 8 years ago.
Testpage
12998.patch (7.0 KB) - added by manklu 8 years ago.
Hack for the paginator. Maybe it's useful.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by manklu

Attachment: test_issue_12998.html added

Testpage

comment:1 Changed 8 years ago by manklu

Copy the testpage to dojox/grid/tests/enhanced.

Changed 8 years ago by manklu

Attachment: 12998.patch added

Hack for the paginator. Maybe it's useful.

comment:2 Changed 8 years ago by manklu

If you want to try the patch, you must modify the testpage slightly.

dojo.addOnLoad(function() {
	var grid;

	grid = new dojox.grid.EnhancedGrid({
		id: "grid1",
		store: test_store[0],
		structure: layout1,
		plugins: plugins1,
		tabIndex: 2
	}, 'grid1');
	grid.startup();

	grid = new dojox.grid.EnhancedGrid({
		id: "grid2",
		store: test_store[0],
		structure: layout2,
		plugins: plugins2,
		tabIndex: 1
	}, 'grid2');
	grid.startup();
});

comment:3 Changed 8 years ago by Evan

Owner: changed from evan to Evan

comment:4 Changed 8 years ago by bill

Milestone: 1.6.21.8

Moving apparently forgotten ticket to 1.8.

comment:5 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:6 Changed 7 years ago by Evan

Milestone: 1.8future
Priority: blockerhigh

This is more like an a11y keyboard focusing issue, so shouldn't be a release blocker.

Also don't think we will be able to get this fully addressed in 1.8 since significant changes will be required.

comment:7 Changed 7 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:8 Changed 7 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.