Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12994 closed defect (fixed)

[patch][ccla] Rework dojox;charting AMD to adapt to new _base modules returned value

Reported by: cjolif Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: Charting Version: 1.6.1
Keywords: amd Cc: ccmitchellusa@…, cjolif@…
Blocked By: Blocking:

Description

_base modules returned values will change to return a hash object of the functions created by the module instead of dojo or one of the module functions.

In some cases we were relying on the fact modules such as dojo/_base/lang where returning dojo. This won't work anymore. We must now rely on the fact that dojo/_base/kernel will return dojo.

The patch (to be attached later) will adapt the code for that.

Attachments (1)

dojox.charting.kernel.patch (120.6 KB) - added by cjolif 8 years ago.
patch to use _base/kernel to import dojo, will require more testing once gfx will use that as well

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by cjolif

Attachment: dojox.charting.kernel.patch added

patch to use _base/kernel to import dojo, will require more testing once gfx will use that as well

comment:1 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [25135]) fixes #12994 rework charting for AMD for new _base modules \!strict

comment:2 Changed 8 years ago by Rawld Gill

(In [25238]) fixed argument list in factory function (args did not match modules in deps vector; removed unused args); refs #12994; !strict

comment:3 Changed 7 years ago by cjolif

In [27867]:

refs #12994. Small AMD cleanups. !strict.

Note: See TracTickets for help on using tickets.