Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1297 closed defect (fixed)

fixPathsInCssText fails to detect all valid URIs

Reported by: Bryan Forbes Owned by: dylan
Priority: high Milestone:
Component: General Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

The regular expression in line 5986 of dojo.js (dojo-0.3.1-ajax, uncompressed) fails to detect all valid URIs:

url += cssStr.match(/[ sw()/.\'"-:#=&?]*)/)[0]; url string

The problem arose when a user from the interest list was using dojo from his university account (http://www.stud.uni-karlsruhe.de/~[USER_NAME]/). This also applies to the regular expression in regexp.js.

Another problem was that when the url doesn't match, it throws an error which should be caught. Also, URI's in comments are parsed as well.

Change History (4)

comment:1 Changed 13 years ago by dylan

Version: 0.40.3

comment:2 Changed 13 years ago by dylan

Resolution: fixed
Status: newclosed

(In [6046]) fixes #1297, missing ~ from url regex

comment:3 Changed 13 years ago by dylan

I think that URI's in comments is only the case when using debugAtAllCosts... if that is not the case, please provide a testcase and open a new ticket.

comment:4 Changed 13 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.