Opened 9 years ago

Closed 8 years ago

#12937 closed defect (fixed)

mobile Scrollable view doesnt work inside tooltip dialog

Reported by: Chris Mitchell Owned by: ykami
Priority: high Milestone: 1.7
Component: DojoX Mobile Version: 1.6.1
Keywords: Cc: doughays@…
Blocked By: Blocking:

Description

Scrollable view has problems when used in a tooltip dialog/Opener. It's common when displaying long lists in a tooltip dialog to need to scroll through them. Opener on a phone display size doesnt work with Scrollable view either.

Attachments (1)

12937.patch (11.4 KB) - added by Douglas Hays 8 years ago.
fix to review

Download all attachments as: .zip

Change History (16)

comment:1 Changed 9 years ago by Chris Mitchell

(In [24878]) refs #12937 test for opener with list inside !strict

comment:2 Changed 9 years ago by Chris Mitchell

This test shows an example of the type of view that's being created. Change the div inside the opener to be a ScrollableView?, and set the height of the div to a fixed number like 350px, you'll see the problems. The non-header portion of this view needs to scroll.

comment:3 Changed 9 years ago by Chris Mitchell

(In [24880]) refs #12937 test for opener with round rect list inside !strict

comment:4 Changed 9 years ago by Chris Mitchell

Added another testcase with RoundRect? select list example.

comment:5 Changed 9 years ago by Chris Mitchell

A similar (related?) bug is that the mobile.View widget inside the opener, its contents are always visible, initially and when the tooltip dialog is closed.

comment:6 Changed 9 years ago by Chris Mitchell

Cc: doughays@… added

Changed 8 years ago by Douglas Hays

Attachment: 12937.patch added

fix to review

comment:7 Changed 8 years ago by Chris Mitchell

(In [25173]) refs #12937 updated roundselectlist test...a bit closer to the desired goal

comment:8 Changed 8 years ago by Chris Mitchell

(In [25174]) refs #12937 updated searchlist test...a bit closer to the desired goal

comment:9 Changed 8 years ago by Douglas Hays

Owner: changed from ykami to Douglas Hays
Status: newassigned

comment:10 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [25176]) Fixes #12937. Changed scrollable to not assume the entire screen height. Adjusted CSS to hide a View since it was hardcoded visibility:visible. Added Cancel/Done? buttons to the 2 testcases since they couldn't work on an iphone in Overlay mode. Made the contact list example automatically close on name select, while the ringtone test requires a Done click (just to change things up). Set the input value to the selection that was made. !strict

comment:11 Changed 8 years ago by ykami

Resolution: fixed
Status: closedreopened

The patch broke test_iPad-Settings.html.

  1. Open test_iPad-Settings.html with Chrome.
  2. Select either of Wi-Fi, Brightness & Wallpaper, or Picture Frame

-> The view height becomes too short.

comment:12 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

(In [25190]) Fixes #12937. Use domNode.scrollHeight instead of containerNode.scrollHeight since the domNode overlay:hidden can truncate the containerNode size. !strict

comment:13 Changed 8 years ago by ykami

Resolution: fixed
Status: closedreopened

Another breakage found. The lower view of test_iPhone-SwapView-demo.html does not resize. Also, the same problem found in the mobile demo gallery.

comment:14 Changed 8 years ago by ykami

Owner: changed from Douglas Hays to ykami
Status: reopenednew

comment:15 Changed 8 years ago by ykami

Resolution: fixed
Status: newclosed

(In [25305]) Fixes #12937 !strict Introduced a new property value, height="auto", for cases where content is smaller than entire screen height. If height="auto" is not explicitly specified, the behavior becomes the same as before.

Note: See TracTickets for help on using tickets.