[patch][trivial]dojox.dtl.filter.string._urlquote incorrectly encodes chars < 16

[thobbs]

In dojox/dtl/filter/string.js, the _urlquote function improperly encodes characters whose ordinal value is less than 16. As specified in ​RFC 1738, a two digit hexadecimal number should follow the '%'. However, characters below 16 are encoded to only use one digit. For example, ASCII character 1 becomes "%1" instead of "%01".

[thobbs]

Patch to encode all characters with two hex digits

[mbulman]

This is marked as 1.6.1, but doesn't seem to be there.. what's the word?

[Adam Peller]

Sorry, it appears no one has taken up this patch. "Version" is the version where the problem was reported. Milestone is the target.

[ben hockey]

thobbs, could you attach a test page that demonstrates the problem that will be fixed by this patch? also, do you have a CLA on file with us?

[trac-o-bot]

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

[ben hockey]

#13669 is a duplicate of this ticket.

[Jonathan]

Problem also reported in #13669 and other code solution provided.

I can't get JsFiddle? to work, so here's the test case. Run this in your console. Both patches will fix this.

// I've used a tab character ("\t") but anything with a hex value
// between 0 and 9 would demonstrate the problem.
var encodedString = dojox.dtl.filter.strings.urlencode("\t");

console.log('Dojo encodes \t as %9 instead of %09');
console.log(encodedString);

// This should output "\t" or whatever was passed to urlencode() 
// but will fail with current implementation
decodeURIComponent(encodedString);

[bill]

neonstalwart, you reopened, were you going to check this in?

[ben hockey]

In [28580]:

pad single digit hex chars with leading 0. fixes #12932 !strict

[ben hockey]

i could never figure out the CLA status of this patch. it probably isn't a big deal but i used some code i came up with myself. apart from that, the patch was fine.