Opened 8 years ago

Closed 8 years ago

#12919 closed defect (invalid)

TabContainer: calls startup() on children twice

Reported by: yiqin yu Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.6.0
Keywords: ContentPane startup Cc:
Blocked By: Blocking:

Description

When place a dijit.layout.ContentPane? in a dijit.layout.TabContainer?, the content pane's startup be called twice.

Attachments (1)

test.jsp​ (844 bytes) - added by yiqin yu 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by yiqin yu

Attachment: test.jsp​ added

comment:1 Changed 8 years ago by bill

Summary: When place a dijit.layout.ContentPane in a dijit.layout.TabContainer, the content pane's startup be called twice → TabContainer: calls startup() on children twice

This isn't an issue in practice because the first line of ContentPane.startup() (like all startup() methods) is: 

if(this._started){ return; }

I'll take a look though.

comment:2 Changed 8 years ago by bill

Component: General → Dijit
severity: normal → minor

comment:3 Changed 8 years ago by bill

Resolution: → invalid
Status: new → closed

This is a user error because your startup() method isn't calling this.inherited(), and thus this._started isn't set on the ContentPane.

It does give me some ideas about simplification of the startup() related code though, which I'll address in a different ticket. (But you'll still need to call this.inherited() in your startup() method.

Note: See TracTickets for help on using tickets.