Opened 9 years ago

Closed 5 years ago

#12905 closed enhancement (patchwelcome)

CheckBox, RadioButton: Control over base text direction (textDir)

Reported by: tomer Owned by:
Priority: high Milestone: 1.13
Component: Dijit - Form Version: 1.6.1
Keywords: Cc: [email protected]…, [email protected]…, [email protected]…
Blocked By: Blocking:

Description (last modified by bill)

The core support was introduced via #12367. In this ticket we address control over base text direction (via textDir parameter) for dijit.form.CheckBox and dijit.form.RadioButton controls.

There is also a dependency on #11611.

Attachments (2)

patch201105091118_Dojo-textDirCheckBox.txt​ (57.1 KB) - added by bill 9 years ago.
original patch from Maria
checkboxTextDir.patch​ (55.8 KB) - added by bill 9 years ago.
updated patch. but, i'm not really interested in having checkbox adjust the textdir of the label unless the label is part of the checkbox.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by bill

Attachment: patch201105091118_Dojo-textDirCheckBox.txt​ added

original patch from Maria

comment:1 Changed 9 years ago by bill

Description: modified (diff)
Summary: Control over base text direction (textDir) for dijit.form.CheckBox and dijit.form.RadioButton → CheckBox, RadioButton: Control over base text direction (textDir)
Type: defect → enhancement

comment:2 Changed 9 years ago by bill

Description: modified (diff)

Changed 9 years ago by bill

Attachment: checkboxTextDir.patch​ added

updated patch. but, i'm not really interested in having checkbox adjust the textdir of the label unless the label is part of the checkbox.

comment:3 Changed 8 years ago by bill

Blocked By: 11611 added

comment:4 Changed 8 years ago by Douglas Hays

Blocked By: 11611 removed

(In #11611) The label in ToggleButton? is different than the LABEL tag - probably just poorly named. Patches are welcome. The generated LABEL element would need to be text-direction aware.

comment:5 Changed 8 years ago by Douglas Hays

Milestone: 1.8 → tbd

comment:6 Changed 8 years ago by bill

Milestone: tbd → 1.9

comment:7 Changed 8 years ago by bill

Milestone: 1.9 → future

Oh, this is the ticket that depends on #11611.

Doug - yes, the label in ToggleButton is different than the LABEL tag typically used with checkboxes and radio buttons, but I think you are missing the point of #11611, which is for an app to be able to instantiate a checkbox+label in the same way that it can currently instantiate a ToggleButton, like new CheckBox({label: "hi"}).

comment:8 Changed 6 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: new → assigned

comment:9 Changed 6 years ago by Douglas Hays

Status: assigned → open

comment:10 Changed 5 years ago by dylan

Milestone: future → 1.12
Resolution: → patchwelcome
Status: open → closed

Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.