Editor: Enter key on blank line jumps to end of content

[mtyson]

This is a high priority one for us.

Basically, when you hit enter when on a blank line, the caret jumps to the end of the editor content.

Verified this occurs with 1.6 codebase, but not 1.5.

Only occurs if EnterKeyHandling? is active. If that plugin is explicitly removed, enter key on blank line is OK.

STEPS: 1) See attached example. 2) Put caret in blank lines between TEST and TEST1. 3) Hit enter key 4) Notice caret jumps to end

NOTE: The attached sample is taken from dojo campus. Only thing changed is added content and switched codebase to 1.6.

[mtyson]

Sample of enter key problem

[bill]

Jared, IIRC you did a big cleanup of EnterKeyHandling, maybe this is fallout from that change?

[Jared Jurkiewicz]

Patch that seems to resolve the issue. Needed ot check offset and insert before the specific offset.

[Jared Jurkiewicz]

(In [24816]) Fixing Enter Key Handling. \!strict refs #12893

[Jared Jurkiewicz]

(In [24817]) Fixing Enter Key Handling. \!strict fixes #12893

[mtyson]

This still repros on the first line (if its blank).

To reproduce: 1) Use the sample 2) Put the caret at the beginning of the first line of content 3) Hit enter a couple times, to move the content down 4) put the caret back at the very first line (which is now blank) 5) hit enter. The caret jumps to the end of content.

summary: Basically, hitting enter at the beginning of the editor content when the line is blank still repros the problem.

[Jared Jurkiewicz]

Follow-on patch, always insert before the offset node.

[Jared Jurkiewicz]

(In [24912]) Follow-on EnterKeyHandling? patch \!strict refs #12893

[Jared Jurkiewicz]

(In [24913]) Follow-on EnterKeyHandling? patch \!strict fixes #12893