Opened 8 years ago
Last modified 3 years ago
#12879 new defect
dojox.rpc modules need proper wrapping for 1.6 builds
| Reported by: | Kenneth G. Franqueiro | Owned by: | Kris Zyp |
|---|---|---|---|
| Priority: | high | Milestone: | 1.15 |
| Component: | Dojox | Version: | 1.6.1 |
| Keywords: | dojox.rpc | Cc: | Dustin Machi |
| Blocked By: | Blocking: |
Description
It appears that in Dojo 1.6, a few of the dojox.rpc modules (namely JsonRPC, JsonRest, OfflineRest, and Rest) are not properly wrapped to safely work after being run through a build; these modules end up leaking globals.
I'm attaching a possible patch (for review) for JsonRest, Rest, and OfflineRest, but I'm not sure exactly what is the right way to deal with JsonRPC, as it doesn't seem to actually populate dojox.rpc.JsonRPC at all.
(Note: since I properly indented everything inside the added closures in the patch, you're probably better off diffing these with a tool that can ignore whitespace...)
This is mainly a concern specifically for 1.6 (in the event we were to have a 1.6.2), though the JsonRPC bit might also be a concern for 1.7+ with the new loader.
Attachments (1)
Change History (6)
Changed 8 years ago by
| Attachment: | 12879.diff added |
|---|
comment:1 Changed 8 years ago by
| Cc: | Dustin Machi added |
|---|---|
| Owner: | changed from Adam Peller to Kris Zyp |
comment:3 Changed 7 years ago by
| Milestone: | 1.8 → 2.0 |
|---|
1.8 has been tagged; moving all outstanding tickets to next major release milestone.
comment:4 Changed 3 years ago by
| Milestone: | 2.0 → 1.12 |
|---|
comment:5 Changed 3 years ago by
| Milestone: | 1.13 → 1.15 |
|---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
Proposed patch alluded to in description