Opened 9 years ago

Last modified 3 years ago

#12879 new defect

dojox.rpc modules need proper wrapping for 1.6 builds

Reported by: Kenneth G. Franqueiro Owned by: Kris Zyp
Priority: high Milestone: 1.15
Component: Dojox Version: 1.6.1
Keywords: dojox.rpc Cc: Dustin Machi
Blocked By: Blocking:

Description

It appears that in Dojo 1.6, a few of the dojox.rpc modules (namely JsonRPC, JsonRest, OfflineRest, and Rest) are not properly wrapped to safely work after being run through a build; these modules end up leaking globals.

I'm attaching a possible patch (for review) for JsonRest, Rest, and OfflineRest, but I'm not sure exactly what is the right way to deal with JsonRPC, as it doesn't seem to actually populate dojox.rpc.JsonRPC at all.

(Note: since I properly indented everything inside the added closures in the patch, you're probably better off diffing these with a tool that can ignore whitespace...)

This is mainly a concern specifically for 1.6 (in the event we were to have a 1.6.2), though the JsonRPC bit might also be a concern for 1.7+ with the new loader.

Attachments (1)

12879.diff (57.4 KB) - added by Kenneth G. Franqueiro 9 years ago.
Proposed patch alluded to in description

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Kenneth G. Franqueiro

Attachment: 12879.diff added

Proposed patch alluded to in description

comment:1 Changed 9 years ago by Adam Peller

Cc: Dustin Machi added
Owner: changed from Adam Peller to Kris Zyp

comment:2 Changed 8 years ago by bill

Milestone: 1.6.21.8

Moving apparently forgotten ticket to 1.8.

comment:3 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

comment:4 Changed 4 years ago by dylan

Milestone: 2.01.12

comment:5 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.