Convert dojox packages to amd

[Chris Mitchell]

Using this ticket for continued work around dojox project conversions to AMD.
Sign up for a conversion by putting your trac id next to the modules below. If you are not a committer, you can still sign up, but attach your patch for each module as u convert and verify by running it's tests.

IMPORTANT: All modules should be converted to use "Base-less" AMD style, with minimal dependencies. See the comments in 12844 about proper style for modules, so that api-doc tool works with your package.
[H] indicates higher priority

Note: As templated Dijit-based widgets in dojox are converted to amd, we should use the new text! dependency injection, rather than dojo.cache. This should be a simple fix, see changeset r24784 for examples of how Bill did this recently for dijit.

color - ttrenka, cjolif - COMPLETE/COMMITTED
collections - ttrenka COMPLETE/COMMITTED
grid - COMPLETE
html - chrism - COMPLETE/COMMITTED
math - COMPLETE/COMMITTED
mobile - dmachi - COMPLETE/COMMITTED
timing - ttrenka COMPLETE/COMMITTED
string - ttrenka COMPLETE/COMMITTED
json - neonstalwart - COMPLETE/COMMITTED
geo - erwan - COMPLETE/COMMITTED (See #12844)
charting - cjolif - COMPLETE/COMMITTED (See #12844, #12642)
gauges - etissandier - COMPLETE/COMMITTED (See #12844)
gfx - eugene - COMPLETE/COMMITTED (See #12844)
gfx3d - etissandier - COMPLETE/COMMITTED
analytics - edchat - COMPLETE/COMMITTED
[H]dtl - edchat - COMPLETE/COMMITTED
[H]lang - ttrenka - IN PROGRESS
[H]css3 - nic COMPLETE/COMMITTED
[H]fx - chrism COMPLETE/COMMITTED
[H]date - peller - COMPLETE / COMMITTED
encoding - BryanForbes - COMPLETE/COMMITTED
io - BryanForbes - COMPLETE / COMMITTED
mdnd - chrism - COMPLETE/COMMITTED
uuid - BryanForbes - COMPLETE/COMMITTED
validate - BryanForbes - COMPLETE/COMMITTED
xml - ttrenka, BryanForbes - COMPLETE/COMMITTED
store - ttrenka - COMPLETE/COMMITTED
sketch - ttrenka - COMPLETE/COMMITTED
embed - TRT
atom
av
calc
cometd
data

[H]CsvStore?.js
[H]HtmlStore?.js
[H]JsonRestStore?.js
[H]KeyValueStore?.js
[H]QueryReadStore?.js
[H]XmlStore?.js
AndOrReadStore?.js
AndOrWriteStore?.js
AppStore?.js
AtomReadStore?.js
CdfStore?.js
ClientFilter?.js
CouchDBRestStore.js
css.js
CssClassStore?.js
CssRuleStore?.js
dom.js
FileStore?.js
FlickrRestStore?.js
FlickrStore?.js
GoogleFeedStore?.js
GoogleSearchStore?.js
HtmlTableStore?.js
ItemExplorer?.js
JsonQueryRestStore?.js
OpenSearchStore?.js
OpmlStore?.js
PersevereStore?.js
PicasaStore?.js
RailsStore?.js
restListener.js
S3Store.js
ServiceStore?.js
SnapLogicStore?.js
StoreExplorer?.js
WikipediaStore?.js

dnd
drawing
editor
flash
form

[H]CheckedMultiSelect - eldon COMPLETE/COMMITTED
[H]MultiComboBox?
[H]RangeSlider?
[H]Rating
[H]TimeSpinner?
[H]TriStateCheckBox - siqi COMPLETE/COMMITTED
[H]Uploader
_FormSelectWidget
_HasDropDown
_SelectStackMixin
BusyButton?
DateTextBox?
DropDownSelect?
DropDownStack?
FileInput - liucougar COMPLETE/COMMITTED
FileInputAuto - liucougar COMPLETE/COMMITTED
FileInputBlind?
FilePickerTextBox?
FileUploader?
ListInput?
Manager
PasswordValidator?
RadioStack?

gantt
help
highlight
image
jq
jsonPath
layout

[H]ContentPane?
[H]ResizeHandle?
[H]GridContainer? - chrism - COMPLETE
[H}GridContainerLite? - chrism - COMPLETE
RotatorContainer?
ScrollPane?
DragPane?
TableContainer?
ExpandoPane?
RadioGroup?
ToggleSplitter?
FloatingPane?
[L]BorderContainer?

NodeList?
rails
robot
rpc
secure
socket
sql
storage
testing
widget

[H]ColorPicker? - chrism - COMPLETE/COMMITTED
[H]Dialog
AutoRotator?
Calendar
CalendarFx?
CalendarViews?
DataPresentation?
DialogSimple?
DocTester?
DynamicTooltip?
FeedPortlet?
FilePicker?
FisheyeList?
FisheyeLite?
Iterator
Loader
Pager
PlaceholderMenuItem - liucougar COMPLETE/COMMITTED
Portlet
Roller
RollingList?
Rotator
SortList?
Standby
TitleGroup?
Toaster
UpgradeBar?
Wizard
[L]AnalogGauge?
[L]BarGauge?

wire
xmpp

[cjolif]

My last attachment is for #12844 instead... Sorry.

[Tom Trenka]

(In [24691]) Apply DojoX Color AMD path from cjolif, refs #12863 !strict.

[Tom Trenka]

(In [24692]) Convert dojox.collections to AMD. Refs #12863 !strict.

[Tom Trenka]

(In [24693]) Convert experimental timing project to AMD loader. Refs #12863 !strict

[Tom Trenka]

(In [24694]) Convert dojox.string to AMD loader format. Refs #12863 !strict

[Ed Chatelain]

[H]dtl - edchat in Progress

[Chris Mitchell]

(In [24696]) refs #12863

[tissandier]

For the info, I am starting work on gfx3d

[tissandier]

I have attached a patch for AMD loader for gfx3d. Please review before commit. I have not reformated the code so that the review of the patch is easier.

[Tom Trenka]

Not sure why the ref message didn't make it, but converted the entry points for collections, color and timing (the three js files in the root of DojoX).

[ben hockey]

@all - has anyone done any testing with a build after the conversion? if i'm not mistaken (ref #12673) we can't do any testing with a build yet. are people planning to run the tests again once a build is possible?

[Chris Mitchell]

there is no build yet, we're running existing test cases against the newly converted modules. Will need to do additional testing of the build system once it's available.

[ben hockey]

(In [24734]) convert dojox.json to AMD refs #12863

[Chris Mitchell]

(In [24742]) refs #12863 dojox/widget/ColorPicker converted to AMD

[Chris Mitchell]

(In [24743]) refs #12863 added async testcase for dojox.widget.ColorPicker?

[Chris Mitchell]

(In [24755]) refs #12863 converted dtl to AMD minimal deps - thanks edchat IBM !strict

[Chris Mitchell]

(In [24756]) refs #12863 missing dtl.js

[Chris Mitchell]

(In [24757]) refs #12863 convert dojox.analytics to AMD minimal deps - thx edchat IBM !strict

[liucougar]

(In [24760]) refs #12863: _DomTemplated is directly under dojox.dtl, not under dom

[Ed Chatelain]

Good catch on _DomTemplated, thanks liucougar.

[Chris Mitchell]

As templated Dijit-based widgets in dojox are converted to amd, we should use the new text! dependency injection, rather than dojo.cache. This should be a simple fix, see changeset r24784 for examples of how Bill did this recently for dijit.

[Chris Mitchell]

(In [24785]) refs #12863 update ColorPicker? to use dojo/text template AMD injection !strict

[Chris Mitchell]

(In [24787]) refs #12863 updated MultiSelectCalendar? to use dojo/text template and added async testcase !strict

[Chris Mitchell]

(In [24788]) refs #12863 updated MultiSelectCalendar? to use dojo/main rather than dojo !strict

[nic]

(In [24792]) refs #12863 updated dojox.fx.ext-dojo.style, dojox.html.ext-dojo.style and dojox.css3.fx !strict

[Chris Mitchell]

(In [24814]) refs #12863 dojox.gfx3d convert to AMD !strict

[Chris Mitchell]

(In [24815]) refs #12863 dojox.gfx3d convert to AMD !strict

[Bryan Forbes]

(In [24843]) Convert dojox.validate to AMD (refs #12863) !strict.

[Bryan Forbes]

(In [24851]) Convert dojox.uuid to AMD (refs #12863) !strict.

[Bryan Forbes]

(In [24852]) Convert dojox.encoding to baseless modules (refs #12863) !strict.

[Tom Trenka]

(In [24853]) Partial conversion of dojox.lang to AMD loader, patch from cjolif. Refs #12863 !strict

[Tom Trenka]

(In [24860]) Convert DomParser? to AMD, refs #12863 !strict

[Bryan Forbes]

(In [24863]) Convert dojox.xml to baseless AMD (refs #12863) !strict.

[Bryan Forbes]

(In [24864]) Convert dojox.io to baseless AMD (refs #12863) !strict.

[Tom Trenka]

(In [24868]) Adjust the AMD definition to be baseless. Refs #12863 !strict

[Tom Trenka]

(In [24871]) Convert sketch to baseless AMD. Refs #12863 !strict

[Eugene Lazutkin]

(In [24897]) gfx: patches from Rawld Gill and Bryan Forbes for the custom gfx loader for sync and async scenarios, thx!, general cleanup, !strict, refs #12863, refs #7617.

[Chris Mitchell]

(In [24899]) refs #12863 converted dojox.fx to AMD \!strict

[Mike Wilcox]

(In [24922]) Refs #12863 - AMD update for dojox.html.styles test.

[Chris Mitchell]

(In [24925]) refs #12863 add domReady! require to test_gfx.html, to fix crashes on ie

[Chris Mitchell]

(In [24926]) refs #12863 dojox.gfx needs to be imported before declaring objects on it

[Mike Wilcox]

(In [24936]) Refs #12863 - AMD update for dojox.av

[Mike Wilcox]

(In [24937]) Refs #12863 - AMD update for dojox.embed.flashVars

[Mike Wilcox]

(In [24938]) Refs #12863 - AMD update, fixed style test

[Eugene Lazutkin]

(In [24940]) gfx: patch from Bryan Forbes for a "baseless" define() args, and the svgweb-aware initialization, txh!, !strict, refs #12863, refs #7617.

[bill]

(In [24946]) Missing dependency of dojo/_base/lang needed for dojo.getObject(), Refs #12863 !strict.

[bill]

(In [24947]) dojo.provide() needs to match the file name, not the object it dojo.declare()'s. Refs #12863 !strict.

[bill]

(In [24948]) dojo.provide() needs to match the file name Refs #12863 !strict.

[bill]

(In [24953]) Fixing bugs causing warnings during build. Refs #12863 !strict.

[bill]

(In [24955]) Fixing test bugs causing warnings during build. The tests still have failures. Refs #12863 !strict.

[bill]

(In [24957]) Fixing bugs causing warnings during build. Refs #12863 !strict.

[bill]

(In [24959]) dojo.provide() needs to match the file name, refs #12863 !strict.

[Mike Wilcox]

(In [25010]) Refs #12863 - AMD update, dojox.form.FileUploader?

[Mike Wilcox]

(In [25011]) Refs #12863 - AMD update, dojox.form.Uploader

[Mike Wilcox]

(In [25016]) Refs #12863 - update uploaders to use _TemplatedMixin

[bill]

(In [25088]) Use dojo/_base/kernel to get dojo reference, and remove direct <script> tags. Unfortunately this code doesn't seem to be working before or after this change, or even in 1.6. Refs #12863 !strict.

[bill]

(In [25089]) Use dojo/_base/kernel to get dojo reference, and remove direct <script> tags. Unfortunately this code doesn't seem to be working before or after this change, or even in 1.6. Refs #12863 !strict.

[bill]

(In [25090]) Use dojo/_base/kernel to get dojo reference, and other dependency list fixes. Refs #12863 !strict.

[bill]

(In [25091]) Use dojo/_base/kernel to get dojo reference, refs #12863 !strict.

[bill]

(In [25092]) Use dojo/_base/kernel to get dojo reference, refs #12863 !strict.

[bill]

(In [25093]) Use dojo/_base/kernel to get dojo reference. Refs #12863 !strict.

[bill]

(In [25094]) Use dojo/_base/kernel to get dojo reference, and other dependency list fixes. Refs #12863 !strict.

[Chris Mitchell]

(In [25138]) refs #12863 updates for amd to gfx3d \!strict

[Chris Mitchell]

(In [25143]) refs #12863 AMD & _base/kernel updates for dojox.color \!strict

[cjolif]

dojox.gfx._base is using dojox without getting a reference on it

[Chris Mitchell]

(In [25167]) refs #12863 updated dtl to use dojo/_base/kernel \!strict

[Chris Mitchell]

(In [25168]) refs #12863 dojox.gfx._base using dojox without getting a reference on it \!strict

[Chris Mitchell]

(In [25226]) refs #12863 dojox/mdnd and dojox/layout/GridContainer amd conversion \!strict

[bill]

(In [25269]) Use dojo/_base/kernel to get pointer to dojo var, refs #12863 !strict.

[Rawld Gill]

(In [25290]) fixed bad module id in deps vector; refs #12863

[ben hockey]

(In [25413]) refs #12314 #12432 #12863 modifying dojox.mvc to make better use of AMD dependencies. !strict

[ben hockey]

(In [25414]) refs #12314 #12432 #12863 removed unneeded 'exports' dep in dojox/mvc/Bind.js !strict

[Adam Peller]

(In [25503]) Add missing dependency. Refs #12863 \!strict

[bill]

(In [25520]) fix missing dependency on dojo/_base/kernel, fixes #12850, refs #12863, #13208 !strict.

[Adam Peller]

(In [25604]) AMD updates, thanks kitsonk. Fixes #13223, refs #12863

[Adam Peller]

(In [25652]) AMD conversion. fixes #13331, refs #12863 \!strict

[liucougar]

(In [25741]) refs #12863: convert PlaceholderMenuItem? to AMD

[liucougar]

(In [25742]) refs #12863: fixed wrong AMD vector in dojox/validate/_base

[liucougar]

(In [25743]) refs #12863: convert FileInput/FileInputAuto? to AMD

[Colin Snover]

amd conversion for dojox.data.OpenSearchStore?

[Colin Snover]

dojox.data.OpenSearchStore? conversion

[Colin Snover]

dojox.atom conversion

[Colin Snover]

The dojox.data.OpenSearchStore.2.patch is the correct file; I failed to correctly check the “override attachment” checkbox. ttrenka, this file has been updated to reflect the review you provided in IRC.

dojox.atom.widget has some bugs, but they are not caused by the AMD conversion, so I did not fix them.

[Colin Snover]

Oops, I forgot to mention, I did check all tests to make sure things passed and were functional, though only in Firefox 5.

I will pick up the high priority stuff later tonight/tomorrow and hopefully get most of it cleared by tomorrow evening.

[Colin Snover]

ContentPane, ResizeHandle. Also updates dojox.html._base which is a dependency for ContentPane

[Colin Snover]

dojox.embed.QuickTime and dojox.embed.!Object, w/ new resource to fix QuickTime test, & cleanup of unused Eolas stuff

[Colin Snover]

dojox/html.js

[Rawld Gill]

(In [25756]) fixed/replaced some lingering legacy loader API with AMD API; refs #12863

[Colin Snover]

Please note that dojox.form.PasswordValidator is broken; this is not due to the conversion afaik, it is broken in 1.6 too due to change from getDescendants to _getDescendantFormWidgets. I fixed some parts so it at least is partially functioning in 1.7 but the oldPassword box does not work right and many tests still fail.

[Colin Snover]

That should read, “broken in 1.6 too due to change from getDescendants to _getDescendantFormWidgets in dijit._FormMixin._getValueAttr.”

(would love to be able to edit my comments since I make lots of mistakes ;))

[Colin Snover]

All remaining unconverted dojox.form widgets, plus a fix to dojox/data/demos/stores/filestore_dojotree.php for strict mode php5.3 which is necessary for some dojox.form tests

[Brian Carstensen]

CheckedMultiSelect? now uses _TemplatedMixin and _WidgetsInTemplateMixin

[Brian Carstensen]

Ugh, apologies for attaching that patch to this completely unrelated issue. I'll make a proper issue for it when I get a moment.

[bill]

(In [25807]) Patch from csnover (CLA on file) to convert OpenSearchStore to AMD format, thanks! Refs #12863 !strict.

[bill]

(In [25808]) Patch from csnover (CLA on file) to convert OpenSearchStore to baseless AMD, thanks! Refs #12863 !strict.

[bill]

(In [25809]) Patch from csnover (CLA on file) to convert dojox/atom to AMD, thanks! Refs #12863 !strict.

[bill]

(In [25810]) Patch from csnover (CLA on file) to convert dojox/atom NLS files to new format, thanks! This is the first half of the files (since SVN keeps timing out when I commit then altogether :-( ). Refs #12863 !strict.

[bill]

(In [25811]) Patch from csnover (CLA on file) to convert dojox/atom NLS files to new format, thanks! This is part of the files (since SVN keeps timing out when I commit then altogether :-( ). Refs #12863 !strict.

[bill]

(In [25812]) Patch from csnover (CLA on file) to convert dojox/atom NLS files to new format, thanks! This is the final group of the files (since SVN keeps timing out when I commit then altogether :-( ). Refs #12863 !strict.

[bill]

(In [25813]) Patch from csnover (CLA on file) to convert dojox/layout/ContentPane and ResizeHandle to AMD format. Also updates dojox.html._base which is a dependency for ContentPane?. Thanks! Refs #12863 !strict.

[bill]

(In [25814]) Patch from csnover (CLA on file) to convert dojox/html.js to AMD format. Thanks! Refs #12863 !strict.

[bill]

(In [25816]) Patch from csnover (CLA on file) to convert remaining dojox/form files to AMD format, plus a fix to dojox/data/demos/stores/filestore_dojotree.php for strict mode php5.3 which is necessary for some dojox.form tests. Thanks! Refs #12863 !strict.

[bill]

(In [25817]) Patch from csnover (CLA on file) to convert dojox.embed.QuickTime and dojox.embed.Object to AMD format, w/new resource to fix QuickTime? test, & cleanup of unused Eolas stuff Thanks! Refs #12863 !strict.

[bill]

(In [25824]) Missing dojo/_base dependencies, refs #12863 !strict. Since this module apparently has no tests, I couldn't test the change.

[bill]

(In [25826]) Various fixes to dojox.date AMD refactor, including:

1. fix missing dojo.declare dependency
2. some code loaded dojo/_base/kernel but expected all of dojo/_base; changed that code to load dojo/main
3. fixed code that loaded dojo/_base/kernel as "d" rather than "dojo", but then acessed "dojo" as a global

Refs #12863 !strict.

[bill]

(In [25827]) Fix DTL AMD conversion errors:

1. fix loading dojo/_base/kernel as a name other than dojo, then referencing dojo as a global variable
2. missing dojo.json dependency

Refs #12863 converted dtl to AMD minimal deps - thanks edchat IBM !strict

[bill]

(In [25831]) Fix missing dojo.declare references, refs #12863 !strict.

[bill]

(In [25832]) Fix missing dependencies, and access dojox as a global, as per the convention followed in other modules. Refs #12863 !strict.

[bill]

(In [25833]) Fixes to lang/functional AMD conversion, refs #12863 !strict. I ran runTests.html but not sure if that tests the functional package?

[bill]

(In [25839]) Fix AMD conversion errors, refs #12863 !strict.

[bill]

(In [25840]) Fix AMD conversion errors. Some of these files were using dojo/_base/kernel as though it brought in everything in _base; I just changed them to load dojo/main. Refs #12863 !strict.

[bill]

(In [25841]) Fix missing dependency for dojo.declare. Refs #12863 !strict.

[bill]

(In [25843]) Fix AMD conversion errors and use baseless. Refs #12863 !strict.

[bill]

(In [25846]) Fix missing dependencies for MDND, refs #12863 !strict

[bill]

(In [25847]) Fix missing dependencies for GridContainer, refs #12863 !strict

[bill]

(In [25848]) Fix missing dependencies for dojox/mobile/_compat, refs #12863 !strict

[bill]

(In [25849]) Fix missing dependencies for dojox/timing, refs #12863 !strict

[Adam Peller]

(In [25862]) Use dependency list. Refs #12863

[Adam Peller]

(In [25863]) Use dependency list. Still need to fix i18n reference. Refs #12863

[bill]

(In [25865]) Fix missing dependencies for dojox.widget.ColorPicker. Refs #12863 !strict.

[bill]

(In [25866]) Fix AMD conversion errors for dojox/xml. Refs #12863 !strict.

[Chris Mitchell]

updated dojox/dtl for baseless amd, thx edchat IBM ccla

[Chris Mitchell]

In [26009]:

refs #12863 fix up sniff return references as has tests in gfx modules \!strict

[Chris Mitchell]

In [26010]:

refs #12863 continued AMD return value fixes and bug fixes for charting \!strict

[Chris Mitchell]

In [26011]:

refs #12863 continued AMD return value fixes and bug fixes for charting \!strict

[Chris Mitchell]

In [26012]:

refs #12863 continued AMD return value fixes and bug fixes for charting \!strict

[Chris Mitchell]

In [26029]:

refs #12863 use return values in dojox/widget/ColorPicker \!strict

[bill]

In [26078]:

remove global dijit references, refs #12863 !strict.

[bill]

In [26086]:

Use dijit/_base/lang for getObject(), and dijit/registry for byId() etc. Refs #12863 !strict.

[ben hockey]

In [26130]:

fix mistakes introduced by r26086. refs #12863 !strict

[ben hockey]

In [26133]:

change dojo/date/locale.js to use return value from lang module. refs #12863. !strict

[Douglas Hays]

In [26175]:

Refs #12863. atom widget was using non-existent domStyle.style method. Fixed module return value typo in Chart.js. !strict

[Douglas Hays]

In [26176]:

Refs #12863. dojox/embed component was using non-existent marginBox method. !strict

[Douglas Hays]

In [26196]:

Refs #12863. Change nonexistent style method to set. !strict

[bill]

In [26208]:

fix typo in [26003], refs #12863 !strict

[bill]

In [26225]:

fix typo from baseless conversion, thanks cjolif, fixes #13687, refs #12863 (specifically [25968]), !strict

[Chris Mitchell]

In [26238]:

refs #12863 update dojox/html to min AMD \!strict

[Colin Snover]

chrism, your last patch violates many many code conventions. Please see my comment on #13699 and review all of your last patch set for violations. Also kgf pointed out you may have broken the doc parser? Please check preview.php to make sure that docs still work correctly.

[ben hockey]

Replying to csnover:

chrism, your last patch violates many many code conventions.

to be fair to chrism... it doesn't break "many many code conventions." afaict it breaks 1 convention - many times. only constructors start with capitals and abbreviations and acronyms should not be uppercase - although this has not been followed strictly throughout dojo. (maybe that's 2 conventions)

[Chris Mitchell]

In [26273]:

refs #12863 converted dojox.fx modules to AMD with minimal deps. \!strict

[Chris Mitchell]

In [26274]:

refs #12863 converted dojox.fx modules to AMD with minimal deps. \!strict

[Chris Mitchell]

In [26275]:

refs #12863 converted dojox.css3 package to AMD with minimal deps. \!strict

[Chris Mitchell]

In [26296]:

refs #12863 include of dojo._base.fx and dojo.fx.Toggler are now only automatic when using sync loader. thx wildbill

[Adam Peller]

In [26298]:

AMD conversion, refs #12863

[Chris Mitchell]

In [26300]:

refs #12863 fix for dynamic loading of Toggler in dojo/fx.js

[cjolif]

Potential patch to be able to use dojo/number and dijit/Tooltip condittionaly. That is only if they have been loaded. If not then do not use them.

[Chris Mitchell]

In [26307]:

refs #12863 more AMD updates for dojox.dtl. Thanks pruzand IBM CCLA. \!strict

[Chris Mitchell]

In [26308]:

refs #12863 more AMD updates for dojox.dtl. Thanks pruzand IBM CCLA. \!strict

[cjolif]

Additiona fixes on AMD for charting themes

[cjolif]

duplicate some charting tests to AMD syntax (+async for some of theme) to better test charting AMD

[cjolif]

Patch rework after mailing list discussion to avoid try { require} catch for axis where I can dynamically load the tooltip as the truncation is not on by default

[Chris Mitchell]

In [26343]:

refs #12863 updated dynamic loading of Tooltip and number modules in charting per ml discussion. thx Christophe Jolif @ IBM \!strict

[Chris Mitchell]

In [26360]:

refs #12863 fix incorrect module import in dojox.charting.plot2d.common \!strict

[Chris Mitchell]

In [26361]:

refs #12863 AMD updates to mobileFileBrowser demo. \!strict

[Chris Mitchell]

In [26362]:

refs #12863 AMD updates to mobileFileBrowser demo. \!strict

[Chris Mitchell]

In [26364]:

refs #12863 AMD updates to ColorPicker?. \!strict

[Chris Mitchell]

In [26365]:

refs #12863 fix ready() blocks in mobile demos, part of AMD port\!strict

[Chris Mitchell]

In [26366]:

refs #12863 mobileGeoCharting AMD update \!strict

[Chris Mitchell]

In [26367]:

refs #12863 mobileGeoCharting amd updates\!strict

[Chris Mitchell]

In [26374]:

refs #12863 The mobile demo for OpenLayers? is now AMD baseless.
All demos are using data-dojo-type, data-dojo-config, the style

Some fixes in the demos themselves and in in the OpenLayer?'s AMD.

The gauge's tooltip is not using the controversial 'try/catch' anymore.

I have test all ILOG demos on the 3 platforms. Seems ok now, I hope it's ready for beta.\!strict

[Chris Mitchell]

This last patch to demos and gauges is from Emmanuel Tissandier @ IBM. Thanks!

[Chris Mitchell]

In [26390]:

refs #12863 update dtl to work with async true. thanks pruzand@ibm \!strict

[Chris Mitchell]

renamed patch from edchat @ ibm to make viewable with trac

[bill]

I looked over the analytics-12863.patch but since I know nothing about analytics it doesn't mean much Our policy to have module owners review patches has gone out the window for 1.7, partially because many dojox modules are abandoned. Anyway, the patch looks generally good although I didn't run the tests; someone definitely should. Issues I saw are:

• _base.js references a global dojox variable, it should be calling getObject("dojox.analytics")
• base.js changed dojo._toArray(arguments) to ._toArray(arguments), although doesn't matter since it's in a comment
• the return statements in many modules still hardcode the dojox variable, for example: return dojox.analytics.plugins.mouseClick. Also the return statements could be simplified, instead of doing: foo = ..., return foo just do return (foo = ...)
• mouseOver.js adds a "true" final parameter to on() that seems unnecessary, were you confusing on() with aspect.after()?

Also, about dojo.js: With the conversion of the rest of the code base to AMD not sure this works anymore. There might not even be a dojo variable in extreme cases. That's a separate issue from the conversion of analytics to AMD, but worth mentioning.

[Chris Mitchell]

In [26393]:

fixes #12863 add async examples to dtl demos \!strict

[Ed Chatelain]

Updated analytics amd patch, with updates from Bill's comments. I ran the test_analytics.html successfully and added test_analytics-async.html, I also verified that the GoogleAnalytics? tests got thru the Urchin.js code and they failed in the same way they were prior to these changes.

[Chris Mitchell]

In [26409]:

refs #12863 convert dojox.analytics to amd. Thanks edchat @ ibm \!strict

[Chris Mitchell]

This completes the dojox AMD ports for 1.7 under this ticket. We will be opening up individual enhancement tickets for any dojox packages that are still in a partially migrated state, or have not yet been migrated to AMD with minimal dependencies.

[cjolif]

In [26538]:

Refs #12863. Now that DTL supports async AMD, use async:true in AMD charting demo.

[cjolif]

In [26637]:

fix dojox.data.buddhist return value. Refs #12863.

[ben hockey]

In [26640]:

updated dojox.profile.js to squelch warnings during build.

as packages are converted to AMD, the profile can be updated to reflect
that those packages can now be tagged as AMD for the build.

refs #13897, #12863

[Adam Peller]

In [26714]:

Refs #12863

[tomc974]

[CLA] Convert dojox.NodeList?.delegate to AMD format (include async test)

[Kenneth G. Franqueiro]

In [26769]:

Fix dojox/json/schema reference in JRS; refs #12863

[cjolif]

In [27211]:

refs #12863. Fix AMD. !strict.

[Kenneth G. Franqueiro]

Replying to cjolif:

In [27211]:

refs #12863. Fix AMD. !strict.

Should this go into 1.7 branch as well? (Speaking of which, thanks for your other AMD fix yesterday, btw)

[cjolif]

Replying to kgf:

Replying to cjolif:

In [27211]:

refs #12863. Fix AMD. !strict.

Should this go into 1.7 branch as well? (Speaking of which, thanks for your other AMD fix yesterday, btw)

Indeed it should go in 1.7 as well. Do I need to create a new ticket for that or can I just commit with that ticket as reference?

[Kenneth G. Franqueiro]

Replying to cjolif:

Replying to kgf:

Replying to cjolif:

In [27211]:

refs #12863. Fix AMD. !strict.

Should this go into 1.7 branch as well? (Speaking of which, thanks for your other AMD fix yesterday, btw)

Indeed it should go in 1.7 as well. Do I need to create a new ticket for that or can I just commit with that ticket as reference?

Separate ticket would technically be best because it makes it trackable under the 1.7.1 milestone, though I realize that's laborious for something this small. I've already noticed a couple other 1.7.1 fixes batched with tickets that are not specific to 1.7.1.

[cjolif]

In [27613]:

refs #12863. Clean up dojox/css3 AMD. !strict.

[bill]

In [28651]:

fix AMD conversion and doc comments, refs #12863, #13101 !strict

[bill]

In [28656]:

Tweaks to the AMD conversion, although really each class, or at least each widget, should be in its own file. Refs #12863 !strict

[bill]

In [28698]:

fix refactoring errors from [28656], fixes #15435, refs #12863 !strict.

[cjolif]

In [28757]:

refs #12863. Improvements to Colorspace AMD. !strict.

[bill]

In [28907]:

dojox/av: continue AMD update (but it's still not baseless), refs #12863 !strict

PS: note that AV is broken both before and after this checkin.

[bill]

In [28918]:

Continue AMD update, but note that highlight and MultiSelectCalendar are broken both before and after this change, refs #12863 !strict

[Kitson Kelly]

In [29340]:

update non-AMD modules in dojox.profile.js, refs #12863

[Colin Snover <github.com@…>]

In 27533ab2144f77ecd5baebc7be1b079ca2446aef/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 1fee2371205ed90bfbb48faf393758dfe0268ff3/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 523c19d973187e8966ca7c954c5b48d5bc0f371e/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 4a9fb88f4ed230f10a741e2c8745b491c374e575/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 45049b9648dac95d9ba0f23eb090d7794bb9473b/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?