Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1286 closed defect (fixed)

Using reserved word "namespace" for some variable names

Reported by: James Burke Owned by: Adam Peller
Priority: high Milestone:
Component: General Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

"namespace" is a reserved word for JavaScript?/ECMAScript. It is being used as a variable name at least in src/uri/Uri.js (for the nsUri function). The rest of the code should be scrubbed too.

See ​http://www.mozilla.org/js/language/es4/core/lexer.html

Attachments (2)

namespace-r5427.patch​ (8.2 KB) - added by Adam Peller 13 years ago.
keyword patches to parser code
namespace-storage-r5427.patch​ (2.6 KB) - added by Adam Peller 13 years ago.
keyword patches to storage code

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by dylan

Owner: changed from anonymous to dylan
Status: new → assigned

comment:2 Changed 13 years ago by dylan

Resolution: → fixed
Status: assigned → closed

fixed in [5324]

comment:3 Changed 13 years ago by Adam Peller

Resolution: fixed
Status: closed → reopened

Sorry, Dylan, there are lots more of these, and I'm to blame. Most came from Shane's patch. I've been fixing them incrementally, but I need to do more.

comment:4 Changed 13 years ago by Adam Peller

Owner: changed from dylan to Adam Peller
Status: reopened → new

comment:5 Changed 13 years ago by Adam Peller

as of now:

src/storage/browser.js src/widget/DomWidget.js src/widget/Manager.js src/widget/Parse.js src/widget/TreeV3.js src/widget/Widget.js src/xml/Parse.js src/namespace.js src/storage.js

comment:6 Changed 13 years ago by Adam Peller

(In [5417]) references #1286 -- illegal use of namespace keyword

Changed 13 years ago by Adam Peller

Attachment: namespace-r5427.patch​ added

keyword patches to parser code

Changed 13 years ago by Adam Peller

Attachment: namespace-storage-r5427.patch​ added

keyword patches to storage code

comment:7 Changed 13 years ago by Adam Peller

(In [5464]) namespace keyword - references #1286

comment:8 Changed 13 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [5465]) namespace keyword - fixes #1286

comment:9 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.