Async Load of "url" of IconItem is broken due to incorrect scope

[Ming Zhe Huang]

The following definition of an IconItem? used to work. <li dojoType="dojox.mobile.IconItem?" label="url-async" icon="icon.png" url="test.html" transition="slide" sync="false"></li>

It's broken now in trunk, due to AMD refactoring. If you click the icon, there will be error message like: "Failed to load test.html TypeError?: Object [object DOMWindow] has no method 'transitionTo'"

The root cause is inside transitionTo() of _ItemBase. If the loading is async, then it will first use xhr to get the target HTML. However, "this" attached to the callback is wrong. "this" passed in by require() is the global, not the current scope. The fix just bind the current scope to the callback of require().

[Ming Zhe Huang]

proposed patch

[Chris Mitchell]

fixed in [24635]