Opened 8 years ago

Closed 8 years ago

#12842 closed enhancement (fixed)

[patch] [cla] Quote certain properties that match external names

Reported by: Stephen Chung Owned by: Eugene Lazutkin
Priority: lowest Milestone: 1.7
Component: General Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Properties of certain classes are designed to match with external names (e.g. colors) or to be matched by string (e.g. handleAs for dojo.xhr).

Attachments (1)

dojo.quotes.patch (11.5 KB) - added by Stephen Chung 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Stephen Chung

Attachment: dojo.quotes.patch added

comment:1 Changed 8 years ago by bill

Milestone: 1.6.2tbd
Summary: Quote certain properties that match external names[patch] [cla] Quote certain properties that match external names

comment:2 Changed 8 years ago by Stephen Chung

Recommend: quote properties for classes that are designed to match external names, or to be matched by string. Reasons:

1) It allows the reader to see at a glance which classes contain properties with names that are significant as text (i.e. may break code if the properties change).

2) It allows addition of properties in the future with illegal characters that must be quoted without being inconsistent.

3) It does not impact gzipped size.

4) The Closure Compiler will not touch quoted properties, but will attempt to rename ones that are not quoted. This is not a very important use case, as this can also be handled via a post-processing pass.

comment:3 Changed 8 years ago by Eugene Lazutkin

Milestone: tbd1.6.2
Owner: set to Eugene Lazutkin
Status: newassigned

comment:4 Changed 8 years ago by Eugene Lazutkin

Milestone: 1.6.21.7

comment:5 Changed 8 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [24606]) Quoted external names to be more Closure-friendly, thx schungx!, !strict, fixes #12842.

Note: See TracTickets for help on using tickets.