Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12841 closed enhancement (fixed)

[patch] [cla] patches

Reported by: Stephen Chung Owned by: ykami
Priority: low Milestone: 1.8
Component: DojoX Mobile Version: 1.6.0
Keywords: Cc: bill
Blocked By: Blocking:


Suggested change of "touchstart", "touchmove" and "touchend" to "ontouchstart", "ontouchmove", and "ontouchend".

Attachments (1) (1.2 KB) - added by Stephen Chung 11 years ago.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by Stephen Chung

Attachment: added

comment:1 Changed 11 years ago by bill

Component: GeneralDojoX Mobile
Milestone: 1.6.2tbd
Owner: set to ykami
Summary: patches[patch] [cla] patches

comment:2 Changed 11 years ago by ykami

Cc: bill added

Thank you for the patch.

Bill, should we use ontouch* rather than touch*?

comment:3 Changed 11 years ago by bill

Oh I'm not sure, I was hoping you would know. It seems more consistent so I guess you should use it, but I wanted you to at least test it on iPhone and android.

comment:4 Changed 11 years ago by Stephen Chung

I believe the browser accepts both, but the "on"-prefixed versions seem a bit more common on the web.

Also, if we use the "on"-prefixed versions, it is more consistent since all events starting with "on" and all-lowercase (except certain WebKit?-specific events) are fired by the DOM.

That is assuming the user sticks with the Dojo-recommended style of naming Dojo events in camel case.

comment:5 Changed 11 years ago by bill

Yes, using "on" is more standard when using _WidgetBase.connect() or dojo.connect(). But once we move to using dojo/on (instead of dojo.connect()), we can't use the "on" prefix to event names anymore.

comment:6 Changed 11 years ago by ykami

Resolution: fixed
Status: newclosed

In [27388]:

Fixes #12841 !strict Added "on"-prefix to touchstart, touchmove, and touchend.

comment:7 Changed 11 years ago by ykami

Milestone: tbd1.8

Thank you for the comment:4. I added the prefix.
Thank you Bill for the precaution regarding dojo/on.

comment:9 Changed 11 years ago by ykami

Thanks for the info, but anyway we might move to dojo/on in the end.

Note: See TracTickets for help on using tickets.