dojo.store.Observable does not observe correctly an added Object.

[Simon Speich]

Objects added to the store, where the store creates the id, are not observed correctly:

• store.remove() is not observed at all
  
• store.put() is observed as -1 >-1 instead of >-1 >-1

  var store, res, id;
  store = new dojo.store.Memory({
  	data: [
  		{id: 1, parId: 2}
  	]
  });
  store = dojo.store.Observable(store);
  res = store.query({
  	parId: 2
  });
  res.observe(function(item, removedFrom, insertedInto) {
  	console.log(removedFrom, insertedInto);
  }, true);
  
  id = store.add({
  //	id: 2,
  	parId: 2
  });
  var obj = store.get(id);
  store.put(obj);
  store.remove(id);
  
  

incorrectly logs as:

-1 1
-1 1

removing the comment id: 2
correctly logs as:

-1  1
 1  1
 1 -1

[Kris Zyp]

In [26097]:

Keep results array in sync, refs #12835 !strict

[Simon Speich]

When adding an object without an id to the store with store.add(), the store creates and returns the id, but does not add it to the object. Is that the intentional behavior? If so I think it's confusing and should be mentioned in the docs.

If I add the returned id to the object before calling store.put() in the above code example

obj.id = id;
store.put(obj);

then observe() works correctly. I guess this means that, this defect occurs, because the object does not have an identity property (and depending on the correct behavior of add() this defect could be closed).

[bill]

This needs an automated test case. Also need to set the milestone on the ticket.

[bill]

Oh, looks like it was fixed in [27072], for 1.8, and test case was added there.

[Simon Speich]

If I use the JsonRest? store instead of the Memory store, I get the same problem as explained above. Remove is not observed at all and put is observed as add, e.g.: -1 1 -1 1

[Kenneth G. Franqueiro]

Reopening this, since it sounds like there may still be issues in use with other stores?

[Kris Zyp]

Simon, can you provide more specifics on what the REST responses look like? From what I can tell in my tests, remove() is working and if the response properly includes an id, put() is working properly too.

[Simon Speich]

edited screenshot of REST responses

[Simon Speich]

test file html

[Simon Speich]

I also uploaded the testcase to ​http://www.speich.net/projects/programming/dojo-jsonrest-test.htm I hope I'm not doing something stupid...

[Kris Zyp]

Simon, I think the core issue with this testcase is that your initial query is not returning an array as the JsonRest? store expects. The initial query (store.query({parId: 2})) is returning an object. The subsequent notifications are all acting on that object, and trying to determine index values based on that object. Since indices into object (instead of an array) don't make sense, the from/to index values are incorrect. I would recommend having the initial query return [{id:1,parId:2}].

[Kris Zyp]

I did find an issue with index values being incorrect with paged queries, that I will check in a fix for, but I am not sure if it will fix this test case.

[Kris Zyp]

In [29059]:

Corrected logic for insertedInto index when an object is updated within a paged query, refs #12835 !strict

[Simon Speich]

generates the REST responses for the test

[Simon Speich]

I changed the initial response to an array. Without the fix I still get the same -1 0, -1 0, with the fix its even worse now, I only get -1, 0 and it doesn't make a difference if the initial response is an object or an array.

I updated the test case on speich.net, but since that is pulling in nightly it doesn't contain your fix yet.

[Kris Zyp]

In [29069]:

Adjust the logic for updated objects with stores that don't have a query engine, fixes #12835 !strict