Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12816 closed enhancement (fixed)

Menu: split out DropDownMenu from ContextMenu

Reported by: bill Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

There's lots of code in Menu that's only used for context menus. Make separate widgets for drop-down menus vs. context-menus to avoid loading unneeded code.

For backwards-compatibility reasons the ambiguously named dijit.Menu needs to maintain it's old functionality of being a context menu or a drop down menu.

Change History (4)

comment:1 Changed 8 years ago by bill

(In [24570]) add hints to test, refs #12816

comment:2 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

(In [24630]) Menu refactor to split out the context menu (with special code for binding to nodes and watching for right-click event) from the plain drop-down menu.

For backwards-compatibility dijit.Menu retains the context-menu functionality, and the plain menu is called dijit.DropDownMenu.

Patch from Akira Sudoh (IBM, CCLA), thanks! Fixes #12816 !strict.

comment:3 Changed 8 years ago by bill

(In [24872]) remove unused dependencies, refs #12816 !strict.

comment:4 Changed 8 years ago by bill

(In [25392]) Unfortunately, Menu etc. can't extend _WidgetBase instead of _Widget because we lose deprecated methods like attr(). Refs #12816 !strict.

Note: See TracTickets for help on using tickets.